From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Make vm eviction uninterruptible Date: Tue, 8 Apr 2014 21:11:39 -0700 Message-ID: <20140409041139.GB2271@bwidawsk.net> References: <20140405203412.GH8475@nuc-i3427.alporthouse.com> <20140406024527.GA31750@intel.com> <20140406183502.GA4414@bwidawsk.net> <20140407094256.GI8475@nuc-i3427.alporthouse.com> <20140407121500.GE9262@phenom.ffwll.local> <20140407123004.GJ8475@nuc-i3427.alporthouse.com> <20140407185828.GA18726@bwidawsk.net> <20140407215006.GF9262@phenom.ffwll.local> <20140407215834.GA19750@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 68B5F6EA4A for ; Tue, 8 Apr 2014 21:11:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 08, 2014 at 08:53:15AM +0200, Daniel Vetter wrote: > On Mon, Apr 7, 2014 at 11:58 PM, Ben Widawsky wrote: > > Blocking important fixes for a test case is harmful to customers of our > > software. I won't argue past that. If you won't take it as is, add it to the > > JIRA task like you said. I'll carry this one around with my dynamic page table > > allocations since you essentially can't do any real workloads with full PPGTT > > without this (assuming you have signals). I'd venture to even say existing > > tests can hit it with full PPGTT turned on. > > A duct-tape bugfix like this would be justified in late -rc, where the > risk for disabling full ppgtt would probably outweight this hack. > Earlier I'd opt of simply re-disbaling full ppgtt again if we can't > come up with a properly understood fix and testcase for it in time. > > But atm full ppgtt is disabled, and we have a task-list with 10 > subtasks on internal JIRA to knock down. Without that I wouldn't > recommend anyone to try to ship full ppgtt in production, especially > not our internal customers. > > I've updated the relevant subtask JIRA with details. > -Daniel I felt confident when I wrote the original email it was hittable without full PPGTT. I am not quite certain now. If that is not the case, I agree with you. -- Ben Widawsky, Intel Open Source Technology Center