From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/6] drm/i915: dma_buf_vunmap is presumed not to fail, don't let it
Date: Wed, 9 Apr 2014 15:03:33 +0200 [thread overview]
Message-ID: <20140409130333.GO9262@phenom.ffwll.local> (raw)
In-Reply-To: <1396900911-12415-3-git-send-email-rodrigo.vivi@gmail.com>
On Mon, Apr 07, 2014 at 05:01:47PM -0300, Rodrigo Vivi wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> Since dma_buf_vunmap() procedes blithely on ignorant of whether the
> driver failed to actually unmap the backing storage for the dma-buf, we
> need to make a best-effort to do so. This involves not allowing
> ourselves to be susceptible to signals causing us to leak the storage.
>
> This should have been detectable with the current i-g-t as a misplaced
> signal should have left the pages pinned upon freeing the object where
> we have a warning in place.
Apparently QA is asleep, or have I missed the bugzilla?
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-09 13:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 20:01 [PATCH 0/6] drm-intel-collector - update Rodrigo Vivi
2014-04-07 20:01 ` [PATCH 1/6] drm/i915: Bring UP Power Wells before disabling RC6 Rodrigo Vivi
2014-04-07 21:36 ` Ben Widawsky
2014-04-08 12:43 ` Ville Syrjälä
2014-04-08 12:52 ` S, Deepak
2014-04-09 4:13 ` Ben Widawsky
2014-04-09 4:21 ` S, Deepak
2014-04-09 13:02 ` Daniel Vetter
2014-04-09 19:15 ` Deepak S
2014-04-09 21:46 ` Ben Widawsky
2014-04-07 20:01 ` [PATCH 2/6] drm/i915: dma_buf_vunmap is presumed not to fail, don't let it Rodrigo Vivi
2014-04-09 13:03 ` Daniel Vetter [this message]
2014-04-07 20:01 ` [PATCH 3/6] drm/i915: Add support for stealing purgable stolen pages Rodrigo Vivi
2014-04-08 4:32 ` Gupta, Sourab
2014-04-08 6:45 ` Chris Wilson
2014-04-08 6:53 ` Gupta, Sourab
2014-04-09 13:06 ` Daniel Vetter
2014-04-10 10:12 ` Gupta, Sourab
2014-04-11 8:55 ` Daniel Vetter
2014-04-14 9:53 ` Gupta, Sourab
2014-04-07 20:01 ` [PATCH 4/6] drm/i915: add flag to prevent dmesg spam on context banning Rodrigo Vivi
2014-04-08 14:04 ` Mika Kuoppala
2014-04-07 20:01 ` [PATCH 5/6] drm/i915: Do not allow a pending forcewake put to unbalance across reset Rodrigo Vivi
2014-04-07 20:01 ` [PATCH 6/6] drm/i915: Don't save/restore RS when not used Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409130333.GO9262@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox