From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/6] drm/i915: dma_buf_vunmap is presumed not to fail, don't let it Date: Wed, 9 Apr 2014 15:03:33 +0200 Message-ID: <20140409130333.GO9262@phenom.ffwll.local> References: <1396900911-12415-1-git-send-email-rodrigo.vivi@gmail.com> <1396900911-12415-3-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D5706E00A for ; Wed, 9 Apr 2014 06:03:35 -0700 (PDT) Received: by mail-ee0-f49.google.com with SMTP id c41so1848625eek.8 for ; Wed, 09 Apr 2014 06:03:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396900911-12415-3-git-send-email-rodrigo.vivi@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, Apr 07, 2014 at 05:01:47PM -0300, Rodrigo Vivi wrote: > From: Chris Wilson > > Since dma_buf_vunmap() procedes blithely on ignorant of whether the > driver failed to actually unmap the backing storage for the dma-buf, we > need to make a best-effort to do so. This involves not allowing > ourselves to be susceptible to signals causing us to leak the storage. > > This should have been detectable with the current i-g-t as a misplaced > signal should have left the pages pinned upon freeing the object where > we have a warning in place. Apparently QA is asleep, or have I missed the bugzilla? > > Signed-off-by: Chris Wilson > Signed-off-by: Rodrigo Vivi Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch