From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 3/6] drm/i915: Add support for stealing purgable stolen pages Date: Wed, 9 Apr 2014 15:06:14 +0200 Message-ID: <20140409130614.GP9262@phenom.ffwll.local> References: <1396900911-12415-1-git-send-email-rodrigo.vivi@gmail.com> <1396900911-12415-4-git-send-email-rodrigo.vivi@gmail.com> <1396931564.19246.3.camel@sourabgu-desktop> <20140408064553.GN8475@nuc-i3427.alporthouse.com> <1396940025.19246.33.camel@sourabgu-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by gabe.freedesktop.org (Postfix) with ESMTP id C46D26E0A6 for ; Wed, 9 Apr 2014 06:06:17 -0700 (PDT) Received: by mail-ee0-f51.google.com with SMTP id c13so1892283eek.10 for ; Wed, 09 Apr 2014 06:06:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1396940025.19246.33.camel@sourabgu-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Gupta, Sourab" Cc: "intel-gfx@lists.freedesktop.org" , "Goel, Akash" List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 08, 2014 at 06:53:03AM +0000, Gupta, Sourab wrote: > On Tue, 2014-04-08 at 06:45 +0000, Chris Wilson wrote: > > On Tue, Apr 08, 2014 at 04:32:02AM +0000, Gupta, Sourab wrote: > > > Hi Rodrigo, > > > In this patch, while freeing the purgeable stolen object, the memory > > > node also has to be freed, so as to make space for new object. We need > > > to call drm_mm_remove_node while freeing obj. > > > > > > The below modification patch was floated earlier for this purpose: > > > http://lists.freedesktop.org/archives/intel-gfx/2014-March/041282.html > > > > Right, I have a v2 locally with the fix you identified. > > -Chris > > > Ok, Thanks Chris. I'd really prefer if someone would pick up all the stolen/create2_ioctl/whatever patches, pack them up into a polished series, add the testcases and submit this all for review and merging. Otherwise this will linger forever and we'll get nowhere. Chris seems swamped with other stuff, so Sourab could you please take a look at this? Please check with your manager that you have sufficient bandwidth to pull this through. Rodrigo, I think you can drop this patch from -collector, it only really makes sense in the context of all the other stolen work. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch