Re: [PATCH 14/71] drm/i915/chv: Add early quirk for stolen

Ville Syrjälä
2014-05-08T14:44:44Z

On Thu, May 08, 2014 at 05:32:21PM +0300, Jani Nikula wrote:
> On Wed, 09 Apr 2014, ville.syrjala@linux.intel.com wrote:
> > From: Daniel Vetter <daniel.vetter@ffwll.ch>
> >
> > Same as on other gen8 devices.
> >
> > Cc: Ingo Molnar <mingo@kernel.org>
> > Cc: H. Peter Anvin <hpa@zytor.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > ---
> > arch/x86/kernel/early-quirks.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
> > index bc4a088..5758f5b 100644
> > --- a/arch/x86/kernel/early-quirks.c
> > +++ b/arch/x86/kernel/early-quirks.c
> > @@ -347,7 +347,8 @@ static struct pci_device_id intel_stolen_ids[] __initdata = {
> > INTEL_HSW_D_IDS(gen6_stolen_size),
> > INTEL_HSW_M_IDS(gen6_stolen_size),
> > INTEL_BDW_M_IDS(gen8_stolen_size),
> > - INTEL_BDW_D_IDS(gen8_stolen_size)
> > + INTEL_BDW_D_IDS(gen8_stolen_size),
> > + INTEL_CHV_PCI_IDS(gen8_stolen_size)
>
> Needs refresh after the update to the #define.

This patch is actually wrong. We need CHV specific stolen size detection
here. And in fact we get it as part of patch 34/71. I'll go and split
that up into i915 and x86 specific parts and pretend that this patch
never existed.

>
> Otherwise,
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>
> > };
> >
> > static void __init intel_graphics_stolen(int num, int slot, int func)
> > --
> > 1.8.3.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Technology Center

--
Ville Syrjälä
Intel OTC