From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 5/15] drm/i915: take init power domain for sysfs/debugfs entries where needed Date: Wed, 9 Apr 2014 18:35:21 +0200 Message-ID: <20140409163521.GT9262@phenom.ffwll.local> References: <1396976276-32714-6-git-send-email-imre.deak@intel.com> <1396985681-11522-1-git-send-email-imre.deak@intel.com> <20140409141558.GX9262@phenom.ffwll.local> <1397053307.2552.5.camel@ideak-mobl> <20140409160614.GR18465@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f50.google.com (mail-ee0-f50.google.com [74.125.83.50]) by gabe.freedesktop.org (Postfix) with ESMTP id 992FB6E0B7 for ; Wed, 9 Apr 2014 09:35:24 -0700 (PDT) Received: by mail-ee0-f50.google.com with SMTP id c13so2140055eek.9 for ; Wed, 09 Apr 2014 09:35:23 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140409160614.GR18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 09, 2014 at 07:06:14PM +0300, Ville Syrj=E4l=E4 wrote: > On Wed, Apr 09, 2014 at 05:21:47PM +0300, Imre Deak wrote: > > On Wed, 2014-04-09 at 16:15 +0200, Daniel Vetter wrote: > > > On Tue, Apr 08, 2014 at 10:34:41PM +0300, Imre Deak wrote: > > > > v2: > > > > - make it actually compile, I managed to send the wrong version as = v1 > > > > somehow > > > > = > > > > Signed-off-by: Imre Deak > > > = > > > Usually if we just want the device to be out of D3 we just use > > > intel_runtime_pm_get/put. On a quick look it seems like that's enough= for > > > these places here, too? > > = > > For drpc yes, but for the others we need the DPIO power wells up too. I > > got for all VLV case the power well ref for simplicity, I can change it > > to an RPM ref for drpc, if that's ok. > = > The dpio_info file would need DPIO wells up. However I think we should > just kill that file. It just dumps a small subset of the registers w/o > decoding anything, and we can get more extensive dumps w/ igt, so I > don't see the point of this file. > = > The error handler should already be able to deal with the wells being > down no? > = > The gt_cutr_freq file just talks to the punit so no need for any power > wells either AFAICS. I'm ok with this plan of ripping out useless debugfs files. And if we need a specific set of display power domains then imo we should grab the specific list, not just INIT, i.e. all of them. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch