[PATCH 0/3] Fix up cmd parser OACONTROL handling + refactorings

bradley.d.volkin
2014-03-27T18:43:58Z

From: Brad Volkin <bradley.d.volkin@intel.com>

Patches 1 and 2 do some cleanups suggested as part of the review process.
Patch 3 continues the OACONTROL handling fixes from the other day.

I think patches 1 and 2 are valuable on their own. I think the need/benefit
for the tracking provided by patch 3 is somewhat unclear. Per Ken:

"I don't really buy the snooping problem, though...just because I leave
OACONTROL set doesn't mean I'll get useful data. Another context might
clobber it, and empirically the numbers seem to reset across RC6 anyway.
So in actuality, they're likely to get bogus data.

Even if they did somehow miraculously get decent values, it basically
gives information akin to 'top', which is unprivileged on every system
I've ever used."

That argument makes sense to me, but I've gone ahead and written the patch in
the event that we do want it.

Brad Volkin (3):
drm/i915: BUG_ON() when cmd/reg tables are not sorted
drm/i915: Refactor cmd parser checks into a function
drm/i915: Track OACONTROL register enable/disable during parsing

drivers/gpu/drm/i915/i915_cmd_parser.c | 198 +++++++++++++++++++--------------
1 file changed, 117 insertions(+), 81 deletions(-)

--
1.8.3.2