Re: [PATCH v2 3/3] drm/i915: Track OACONTROL register enable/disable during parsing

Zhenyu Wang
2014-04-10T07:51:44Z

[-- Attachment #1.1: Type: text/plain, Size: 984 bytes --]

On 2014.04.10 08:43:40 +0200, Daniel Vetter wrote:
>
> At least in the case of mesa you _must_ use mesa (or whatever your gl
> library is) to insert the MI_PERF cmd at just the rigth spots in the
> command stream and ofc flush all outstanding vertices and similar things.
>
> If you want a global perf sampling support then I think we need to wire up
> the time-based sampling the hw provides to the perf subsystem. And figure
> out how to coordinate between mesa wanting to use OA and perf (probably
> just reject mesa batches or something like that).
>

yeah, that'll be an interesting direction.

> > Could we have a i915.enable_cmd_parser config that can disable this?
>
> As is I don't see a compelling reason. Also if you require the users of
> your perf tuning tooling to use a module option, you're doing it wrong.
> This stuff should Just Work.

--
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org