From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: Re: [PATCH v2 3/3] drm/i915: Track OACONTROL register enable/disable during parsing Date: Thu, 10 Apr 2014 15:51:39 +0800 Message-ID: <20140410075139.GO15788@zhen-hp.sh.intel.com> References: <1395945820-20376-4-git-send-email-bradley.d.volkin@intel.com> <1396027310-16951-1-git-send-email-bradley.d.volkin@intel.com> <20140410060721.GK15788@zhen-hp.sh.intel.com> <20140410064340.GG9262@phenom.ffwll.local> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0358246389==" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 1AA596E19B for ; Thu, 10 Apr 2014 00:51:44 -0700 (PDT) In-Reply-To: <20140410064340.GG9262@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0358246389== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="V9hgUdtkiYlSaTrE" Content-Disposition: inline --V9hgUdtkiYlSaTrE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2014.04.10 08:43:40 +0200, Daniel Vetter wrote: >=20 > At least in the case of mesa you _must_ use mesa (or whatever your gl > library is) to insert the MI_PERF cmd at just the rigth spots in the > command stream and ofc flush all outstanding vertices and similar things. >=20 > If you want a global perf sampling support then I think we need to wire up > the time-based sampling the hw provides to the perf subsystem. And figure > out how to coordinate between mesa wanting to use OA and perf (probably > just reject mesa batches or something like that). >=20 yeah, that'll be an interesting direction. > > Could we have a i915.enable_cmd_parser config that can disable this? >=20 > As is I don't see a compelling reason. Also if you require the users of > your perf tuning tooling to use a module option, you're doing it wrong. > This stuff should Just Work. --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --V9hgUdtkiYlSaTrE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNGTYsACgkQsQQaM014GCehQACdE8x3YXMT57NpcwUhupjk4FH1 gcwAn2F06tWyGRB4Gq0DClrcsh85xO2g =V6X7 -----END PGP SIGNATURE----- --V9hgUdtkiYlSaTrE-- --===============0358246389== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0358246389==--