Re: [PATCH 4/4] drm/i915: Invalidate our pages under memory pressure

[Daniel Vetter <daniel@ffwll.ch>]

On Fri, Apr 11, 2014 at 09:30:20AM +0100, Chris Wilson wrote:
> On Tue, Mar 25, 2014 at 01:23:06PM +0000, Chris Wilson wrote:
> > Try to flush out dirty pages into the swapcache (and from there into the
> > swapfile) when under memory pressure and forced to drop GEM objects from
> > memory. In effect, this should just allow us to discard unused pages for
> > memory reclaim and to start writeback earlier.
> > 
> > v2: Hugh Dickins warned that explicitly starting writeback from
> > shrink_slab was prone to deadlocks within shmemfs.
> > 
> > Cc: Hugh Dickins <hughd@google.com>
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Good news! QA have declared that this series really does prevent the
> random OOM where we have completely unused swap. So all it needs is
> someone brave enough to review.

Awesome work.

Do we need the additional patch you've just posted to improve the
writeback stalling after calling shrinkers too, or is that not required?

wrt reviewers I'm poking people to get this done from our side. For
merging an ack on the mm pieces would be good so that I can pull it in
through drm-intel trees. My plan is to merge it in 3.16 if it all checks
out.

Cheers, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch