From: Daniel Vetter <daniel@ffwll.ch>
To: Zhao Yakui <yakui.zhao@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/5] drm/i915: Add the support of dual BSD rings on BDW GT3
Date: Fri, 11 Apr 2014 10:57:51 +0200 [thread overview]
Message-ID: <20140411085751.GX9262@phenom.ffwll.local> (raw)
In-Reply-To: <1397177788.2039.192.camel@genxdev-ykzhao.sh.intel.com>
On Fri, Apr 11, 2014 at 08:56:28AM +0800, Zhao Yakui wrote:
> On Thu, 2014-04-10 at 03:04 -0600, Daniel Vetter wrote:
> > On Thu, Apr 10, 2014 at 04:28:34PM +0800, Zhao Yakui wrote:
> > > BTW: Does it need to check all the flags defined in i915_drm.h or the
> > > exported flag returned by i915_get_parameter?
> >
> > I don't have i915_get_parameter anywhere in my sources, so no idea what
> > you mean ...
>
> Sorry that the function should be i915_getparam. It is called by the
> I915_GETPARAM ioctl to query the flag supported by the driver.
Ah, now I understand. The idea is to test all fields of the structure
exhaustively (so also rsvd to make sure it's 0). Well except for the
buffer count field since we have tests for that already.
For the reasons see my two blog posts on the topic:
http://blog.ffwll.ch/2013/11/testing-requirements-for-drmi915.html
http://blog.ffwll.ch/2013/11/botching-up-ioctls.html
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-11 8:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 1:59 [PATCH 0/5] drm/i915: Add the support of dual BSD rings on BDW GT3 Zhao Yakui
2014-04-09 1:59 ` [PATCH 1/5] drm/i915: Split the BDW device definition to prepare for " Zhao Yakui
2014-04-09 14:27 ` Daniel Vetter
2014-04-10 0:44 ` Zhao Yakui
2014-04-09 1:59 ` [PATCH 2/5] drm/i915:Initialize the second BSD ring on BDW GT3 machine Zhao Yakui
2014-04-09 1:59 ` [PATCH 3/5] drm/i915:Handle the irq interrupt for the second BSD ring Zhao Yakui
2014-04-09 1:59 ` [PATCH 4/5] drm/i915:Add the VCS2 switch in Intel_ring_setup_status_page for Gen7 to remove the switch check warning Zhao Yakui
2014-04-09 14:29 ` Daniel Vetter
2014-04-10 0:45 ` Zhao Yakui
2014-04-09 1:59 ` [PATCH 5/5] drm/i915:Use the coarse mechanism based on drm fd to dispatch the BSD command on BDW GT3 Zhao Yakui
2014-04-09 14:34 ` Daniel Vetter
2014-04-10 2:24 ` Zhao Yakui
2014-04-10 6:48 ` Daniel Vetter
2014-04-10 8:04 ` Zhao Yakui
2014-04-10 9:03 ` Daniel Vetter
2014-04-11 0:53 ` Zhao Yakui
2014-04-09 14:45 ` [PATCH 0/5] drm/i915: Add the support of dual BSD rings " Daniel Vetter
2014-04-10 3:28 ` Zhao Yakui
2014-04-10 6:58 ` Daniel Vetter
2014-04-10 8:28 ` Zhao Yakui
2014-04-10 9:04 ` Daniel Vetter
2014-04-11 0:56 ` Zhao Yakui
2014-04-11 8:57 ` Daniel Vetter [this message]
2014-04-14 1:05 ` Zhao Yakui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411085751.GX9262@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox