Re: [PATCH] Revert "drm/i915: fix infinite loop at gen6_update_ring_freq"

Imre Deak
2014-04-28T19:54:25Z

On Mon, 2014-04-28 at 21:23 +0200, Daniel Vetter wrote:
> On Mon, Apr 28, 2014 at 8:14 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> > This can probably be reproduced on non-BDW machines too, with RC6 disabled.
>
> If I understand Imre's patch correctly the bug is that we didn't have
> rc6 on bdw, but the sanitize function didn't make this clear leading
> to bugs.

Yes, that's correct. For runtime PM we require RC6 to be enabled, and we
use intel_enable_rc6() to check for this. Before patch [1]
intel_enable_rc6() reported incorrectly on BDW that RC6 is enabled.

--Imre

[1]
http://lists.freedesktop.org/archives/intel-gfx/2014-April/044354.html

>If my understanding is wrong the I need to drop Imre's patch again.

> -Daniel