From: Damien Lespiau <damien.lespiau@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, benjamin.widawsky@intel.com
Subject: Re: [PATCH] drm/i915/bdw: BDW swizzling in done by the memory controller
Date: Fri, 11 Apr 2014 12:10:33 +0100 [thread overview]
Message-ID: <20140411111033.GA25103@strange.amr.corp.intel.com> (raw)
In-Reply-To: <20140411090903.GA9262@phenom.ffwll.local>
On Fri, Apr 11, 2014 at 11:09:03AM +0200, Daniel Vetter wrote:
> So not yet sold on the story here, at least for gen8/bdw. Apparently
> people haven't screamed about this yet, so it probably works.
Having thought about it a bit more, I don't see how the CPU side would
know about the tiling layout of the surfaces it accesses, so the
remaining options I see:
- we still need to swizzle the address on the CPU side
- bit 6 swizzling for X/Y tiling is just gone and the optimal use of
the RAM is left to the memory controller. If that's the case, we
should see things failing soon enough
So, until any failure case, meh. Just one thing to remember is that the
swizzling bits we set are possibly reserved and may be no-ops.
--
Damien
next prev parent reply other threads:[~2014-04-11 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 16:24 [PATCH] BDW swizzling Damien Lespiau
2014-04-10 16:24 ` [PATCH] drm/i915/bdw: BDW swizzling in done by the memory controller Damien Lespiau
2014-04-11 9:09 ` Daniel Vetter
2014-04-11 9:17 ` Chris Wilson
2014-04-11 11:10 ` Damien Lespiau [this message]
2014-04-11 11:34 ` Daniel Vetter
2014-04-10 17:32 ` [PATCH] BDW swizzling Ben Widawsky
2014-04-10 17:51 ` Damien Lespiau
2014-04-10 22:50 ` Ben Widawsky
2014-04-11 5:58 ` Chris Wilson
2014-04-11 6:39 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140411111033.GA25103@strange.amr.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox