From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/vlv: assert and de-assert sideband reset on resume Date: Fri, 11 Apr 2014 11:15:59 -0700 Message-ID: <20140411111559.08436702@jbarnes-desktop> References: <1397235616-25925-1-git-send-email-jbarnes@virtuousgeek.org> <20140411172624.GG18465@intel.com> <20140411103540.55c01292@jbarnes-desktop> <20140411181021.GI18465@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by gabe.freedesktop.org (Postfix) with SMTP id 149466E417 for ; Fri, 11 Apr 2014 11:14:39 -0700 (PDT) In-Reply-To: <20140411181021.GI18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?UTF-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAxMSBBcHIgMjAxNCAyMToxMDoyMSArMDMwMApWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKCj4gT24gRnJpLCBBcHIgMTEsIDIwMTQg YXQgMTA6MzU6NDBBTSAtMDcwMCwgSmVzc2UgQmFybmVzIHdyb3RlOgo+ID4gT24gRnJpLCAxMSBB cHIgMjAxNCAyMDoyNjoyNCArMDMwMAo+ID4gVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiAKPiA+ID4gT24gRnJpLCBBcHIgMTEsIDIwMTQg YXQgMTA6MDA6MTZBTSAtMDcwMCwgSmVzc2UgQmFybmVzIHdyb3RlOgo+ID4gPiA+IFRoaXMgaXMg YSBiaXQgbGlrZSB0aGUgQ01OIHJlc2V0IGRlLWFzc2VydCB3ZSBkbyBpbiBEUElPX0NUTCwgZXhj ZXB0Cj4gPiA+ID4gdGhhdCBpdCByZXNldHMgdGhlIHdob2xlIGNvbW1vbiBsYW5lIHNlY3Rpb24g b2YgdGhlIFBIWS4gIFRoaXMgaXMKPiA+ID4gPiByZXF1aXJlZCBvbiBtYWNoaW5lcyB3aGVyZSB0 aGUgQklPUyBkb2Vzbid0IGRvIHRoaXMgZm9yIHVzIG9uIHJlc3VtZSB0bwo+ID4gPiA+IHByb3Bl cmx5IHJlLWNhbGlicmF0ZSBhbmQgZ2V0IHRoZSBQSFkgcmVhZHkgdG8gdHJhbnNtaXQgZGF0YS4K PiA+ID4gPiAKPiA+ID4gPiBXaXRob3V0IHRoaXMgcGF0Y2gsIHN1Y2ggbWFjaGluZXMgd29uJ3Qg cmVzdW1lIGNvcnJlY3RseSBtdWNoIG9mIHRoZSB0aW1lLAo+ID4gPiA+IHdpdGggdGhlIHN5bXB0 b20gYmVpbmcgYSAncG9ydCByZWFkeScgdGltZW91dCBhbmQvb3IgYSBsaW5rIHRyYWluaW5nCj4g PiA+ID4gZmFpbHVyZS4KPiA+ID4gPiAKPiA+ID4gPiBJJ20gb3BlbiB0byBiZXR0ZXIgc3VnZ2Vz dGlvbnMgb24gaG93IHRvIGRvIHRoZSBwb3dlciB3ZWxsIHRvZ2dsZSwgd2l0aAo+ID4gPiA+IHRo ZSBleGlzdGluZyBjb2RlIGl0IGxvb2tzIGxpa2UgSSdkIGhhdmUgdG8gd2FsayB0aHJvdWdoIGEg YnVuY2ggb2YKPiA+ID4gPiBwb3dlciBkb21haW5zIGxvb2tpbmcgZm9yIGEgbWF0Y2gsIHRoZW4g Y2FsbCBhIGdlbmVyaWMgZnVuY3Rpb24gd2hpY2gKPiA+ID4gPiB3aWxsIHdhcm4uICBJJ2QgcHJl ZmVyIHRvIGp1c3QgZXhwb3NlIHRoZSBzcGVjaWZpYyBkb21haW5zIGRpcmVjdGx5IGZvcgo+ID4g PiA+IGxvdyBsZXZlbCBwbGF0Zm9ybSBjb2RlIGxpa2UgdGhpcy4KPiA+ID4gPiAKPiA+ID4gPiBT aWduZWQtb2ZmLWJ5OiBKZXNzZSBCYXJuZXMgPGpiYXJuZXNAdmlydHVvdXNnZWVrLm9yZz4KPiA+ ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYyAgICAgfCAg ICA0ICsrLS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgfCAg IDE5ICsrKysrKysrKysrKysrKysrKysKPiA+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcG0uYwo+ID4gPiA+IGluZGV4IGZhMDAxODUuLjNhZmQwYmMgMTAwNjQ0Cj4gPiA+ID4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+ID4gPiBAQCAtNTQ1NCw4ICs1NDU0LDggQEAgc3Rh dGljIGJvb2wgaTl4eF9hbHdheXNfb25fcG93ZXJfd2VsbF9lbmFibGVkKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gPiAgCXJldHVybiB0cnVlOwo+ID4gPiA+ICB9Cj4g PiA+ID4gIAo+ID4gPiA+IC1zdGF0aWMgdm9pZCB2bHZfc2V0X3Bvd2VyX3dlbGwoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiA+IC0JCQkgICAgICAgc3RydWN0IGk5MTVf cG93ZXJfd2VsbCAqcG93ZXJfd2VsbCwgYm9vbCBlbmFibGUpCj4gPiA+ID4gK3ZvaWQgdmx2X3Nl dF9wb3dlcl93ZWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4gPiAr CQkJc3RydWN0IGk5MTVfcG93ZXJfd2VsbCAqcG93ZXJfd2VsbCwgYm9vbCBlbmFibGUpCj4gPiA+ ID4gIHsKPiA+ID4gPiAgCWVudW0gcHVuaXRfcG93ZXJfd2VsbCBwb3dlcl93ZWxsX2lkID0gcG93 ZXJfd2VsbC0+ZGF0YTsKPiA+ID4gPiAgCXUzMiBtYXNrOwo+ID4gPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX3VuY29yZS5jCj4gPiA+ID4gaW5kZXggMmE3MmJhYi4uZjFhYmQyZCAxMDA2NDQKPiA+ ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYwo+ID4gPiA+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gPiA+ID4gQEAgLTM2Myw2 ICszNjMsOSBAQCBzdGF0aWMgdm9pZCBpbnRlbF91bmNvcmVfZm9yY2V3YWtlX3Jlc2V0KHN0cnVj dCBkcm1fZGV2aWNlICpkZXYsIGJvb2wgcmVzdG9yZSkKPiA+ID4gPiAgCXNwaW5fdW5sb2NrX2ly cXJlc3RvcmUoJmRldl9wcml2LT51bmNvcmUubG9jaywgaXJxZmxhZ3MpOwo+ID4gPiA+ICB9Cj4g PiA+ID4gIAo+ID4gPiA+ICt2b2lkIHZsdl9zZXRfcG93ZXJfd2VsbChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiA+ID4gKwkJCXN0cnVjdCBpOTE1X3Bvd2VyX3dlbGwgKnBv d2VyX3dlbGwsIGJvb2wgZW5hYmxlKTsKPiA+ID4gPiArCj4gPiA+ID4gIHZvaWQgaW50ZWxfdW5j b3JlX2Vhcmx5X3Nhbml0aXplKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gPiA+ID4gIHsKPiA+ ID4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZh dGU7Cj4gPiA+ID4gQEAgLTM4MSw2ICszODQsMjIgQEAgdm9pZCBpbnRlbF91bmNvcmVfZWFybHlf c2FuaXRpemUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ID4gPiAgCQlEUk1fSU5GTygiRm91 bmQgJXp1TUIgb2YgZUxMQ1xuIiwgZGV2X3ByaXYtPmVsbGNfc2l6ZSk7Cj4gPiA+ID4gIAl9Cj4g PiA+ID4gIAo+ID4gPiA+ICsJLyoKPiA+ID4gPiArCSAqIEZyb20gVkxWMkEwX0RQX2VEUF9IRE1J X0RQSU9fZHJpdmVyX3ZiaW9zX25vdGVzXzExLmRvY3g6Cj4gPiA+ID4gKwkgKiBOZWVkIHRvIGFz c2VydCBhbmQgZGUtYXNzZXJ0IFBIWSBTQiByZXNldCBieSBnYXRpbmcgdGhlIGNvbW1vbgo+ID4g PiA+ICsJICogbGFuZSBwb3dlciwgdGhlbiB1bi1nYXRpbmcgaXQuCj4gPiA+ID4gKwkgKiBTaW1w bHkgdW5nYXRpbmcgaXNuJ3QgZW5vdWdoIHRvIHJlc2V0IHRoZSBQSFkgZW5vdWdoIHRvIGdldAo+ ID4gPiA+ICsJICogcG9ydHMgYW5kIGxhbmVzIHJ1bm5pbmcuCj4gPiA+ID4gKwkgKi8KPiA+ID4g PiArCWlmIChJU19WQUxMRVlWSUVXKGRldikpIHsKPiA+ID4gPiArCQlzdHJ1Y3QgaTkxNV9wb3dl cl93ZWxsIGNtbl93ZWxsID0gewo+ID4gPiA+ICsJCQkuZGF0YSA9IFBVTklUX1BPV0VSX1dFTExf RFBJT19DTU5fQkMKPiA+ID4gPiArCQl9Owo+ID4gPiA+ICsKPiA+ID4gPiArCQl2bHZfc2V0X3Bv d2VyX3dlbGwoZGV2X3ByaXYsICZjbW5fd2VsbCwgZmFsc2UpOwo+ID4gPiA+ICsJCXZsdl9zZXRf cG93ZXJfd2VsbChkZXZfcHJpdiwgJmNtbl93ZWxsLCB0cnVlKTsKPiA+ID4gPiArCX0KPiA+ID4g Cj4gPiA+IFN0aWNrIHRoaXMgaW50byBpbnRlbF9yZXNldF9kcGlvKCkgaW5zdGVhZD8KPiA+ID4g Cj4gPiA+IEFuZCB3aGF0IGFib3V0IGZhc3Rib290IGFuZCB3aGF0bm90PyBTaG91bGQgd2UgY2hl Y2sgaWYgdGhlIGRpc3BsYXkgaXMKPiA+ID4gYWxyZWFkeSB1cCBhbmQgcnVubmluZyBzb21laG93 IGJlZm9yZSB3ZSBnbyBhbmQga2lsbCBpdCB3aXRoIHRoaXM/Cj4gPiAKPiA+IHJlc2V0X2RwaW8g aXMgdG9vIGxhdGUuCj4gCj4gSG93IGNvbWU/IFdlIHNob3VsZG4ndCB0b3VjaCB0aGUgUEhZIGJl Zm9yZSBpdC4gU28gZWl0aGVyIHJlc2V0X2RwaW8gaXMKPiBpbiB0aGUgd3JvbmcgcGxhY2UgZm9y IHNvbWUgcmVhc29uLCBvciBzb21ldGhpbmcgZWxzZSBnZXRzIGNhbGxlZCB0b28KPiBzb29uLgoK T2ggYWN0dWFsbHkgSSBoYXZlbid0IHRlc3RlZCB3aXRoIGp1c3QgdGhlIGNvbW1vbiByZXNldCwg aXQgbWF5IGJlIG9rCnRvIHB1dCB0aGF0IGludG8gdGhlIERQSU8gaW5pdCBmdW5jdGlvbi4gIE15 IGVhcmxpZXIgcGF0Y2ggd2FzIHRvZ2dsaW5nCmFsbCB0aGUgd2VsbHMsIGluY2x1ZGluZyBkaXNw bGF5LCB3aGljaCB3b3VsZCBvYnZpb3VzbHkgY2xvYmJlciB0aGluZ3MuCgotLSAKSmVzc2UgQmFy bmVzLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=