From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm/i915/vlv: assert and de-assert sideband reset on resume Date: Fri, 11 Apr 2014 11:18:40 -0700 Message-ID: <20140411111840.22da7111@jbarnes-desktop> References: <1397235616-25925-1-git-send-email-jbarnes@virtuousgeek.org> <20140411171632.GM9262@phenom.ffwll.local> <20140411103419.53192616@jbarnes-desktop> <20140411180631.GH18465@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gproxy5-pub.mail.unifiedlayer.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by gabe.freedesktop.org (Postfix) with SMTP id E1F3B6EE1F for ; Fri, 11 Apr 2014 11:17:16 -0700 (PDT) In-Reply-To: <20140411180631.GH18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?UTF-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAxMSBBcHIgMjAxNCAyMTowNjozMSArMDMwMApWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKCj4gT24gRnJpLCBBcHIgMTEsIDIwMTQg YXQgMTA6MzQ6MTlBTSAtMDcwMCwgSmVzc2UgQmFybmVzIHdyb3RlOgo+ID4gT24gRnJpLCAxMSBB cHIgMjAxNCAxOToxNjozMiArMDIwMAo+ID4gRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNo PiB3cm90ZToKPiA+IAo+ID4gPiBPbiBGcmksIEFwciAxMSwgMjAxNCBhdCAxMDowMDoxNkFNIC0w NzAwLCBKZXNzZSBCYXJuZXMgd3JvdGU6Cj4gPiA+ID4gVGhpcyBpcyBhIGJpdCBsaWtlIHRoZSBD TU4gcmVzZXQgZGUtYXNzZXJ0IHdlIGRvIGluIERQSU9fQ1RMLCBleGNlcHQKPiA+ID4gPiB0aGF0 IGl0IHJlc2V0cyB0aGUgd2hvbGUgY29tbW9uIGxhbmUgc2VjdGlvbiBvZiB0aGUgUEhZLiAgVGhp cyBpcwo+ID4gPiA+IHJlcXVpcmVkIG9uIG1hY2hpbmVzIHdoZXJlIHRoZSBCSU9TIGRvZXNuJ3Qg ZG8gdGhpcyBmb3IgdXMgb24gcmVzdW1lIHRvCj4gPiA+ID4gcHJvcGVybHkgcmUtY2FsaWJyYXRl IGFuZCBnZXQgdGhlIFBIWSByZWFkeSB0byB0cmFuc21pdCBkYXRhLgo+ID4gPiA+IAo+ID4gPiA+ IFdpdGhvdXQgdGhpcyBwYXRjaCwgc3VjaCBtYWNoaW5lcyB3b24ndCByZXN1bWUgY29ycmVjdGx5 IG11Y2ggb2YgdGhlIHRpbWUsCj4gPiA+ID4gd2l0aCB0aGUgc3ltcHRvbSBiZWluZyBhICdwb3J0 IHJlYWR5JyB0aW1lb3V0IGFuZC9vciBhIGxpbmsgdHJhaW5pbmcKPiA+ID4gPiBmYWlsdXJlLgo+ ID4gPiA+IAo+ID4gPiA+IEknbSBvcGVuIHRvIGJldHRlciBzdWdnZXN0aW9ucyBvbiBob3cgdG8g ZG8gdGhlIHBvd2VyIHdlbGwgdG9nZ2xlLCB3aXRoCj4gPiA+ID4gdGhlIGV4aXN0aW5nIGNvZGUg aXQgbG9va3MgbGlrZSBJJ2QgaGF2ZSB0byB3YWxrIHRocm91Z2ggYSBidW5jaCBvZgo+ID4gPiA+ IHBvd2VyIGRvbWFpbnMgbG9va2luZyBmb3IgYSBtYXRjaCwgdGhlbiBjYWxsIGEgZ2VuZXJpYyBm dW5jdGlvbiB3aGljaAo+ID4gPiA+IHdpbGwgd2Fybi4gIEknZCBwcmVmZXIgdG8ganVzdCBleHBv c2UgdGhlIHNwZWNpZmljIGRvbWFpbnMgZGlyZWN0bHkgZm9yCj4gPiA+ID4gbG93IGxldmVsIHBs YXRmb3JtIGNvZGUgbGlrZSB0aGlzLgo+ID4gPiA+IAo+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEpl c3NlIEJhcm5lcyA8amJhcm5lc0B2aXJ0dW91c2dlZWsub3JnPgo+ID4gPiA+IC0tLQo+ID4gPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jICAgICB8ICAgIDQgKystLQo+ID4gPiA+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUuYyB8ICAgMTkgKysrKysrKysrKysr KysrKysrKwo+ID4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCj4gPiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+ID4g aW5kZXggZmEwMDE4NS4uM2FmZDBiYyAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9wbS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcG0uYwo+ID4gPiA+IEBAIC01NDU0LDggKzU0NTQsOCBAQCBzdGF0aWMgYm9vbCBpOXh4X2Fs d2F5c19vbl9wb3dlcl93ZWxsX2VuYWJsZWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gPiA+ICAJcmV0dXJuIHRydWU7Cj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4g LXN0YXRpYyB2b2lkIHZsdl9zZXRfcG93ZXJfd2VsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gPiA+ID4gLQkJCSAgICAgICBzdHJ1Y3QgaTkxNV9wb3dlcl93ZWxsICpwb3dl cl93ZWxsLCBib29sIGVuYWJsZSkKPiA+ID4gPiArdm9pZCB2bHZfc2V0X3Bvd2VyX3dlbGwoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiA+ICsJCQlzdHJ1Y3QgaTkxNV9w b3dlcl93ZWxsICpwb3dlcl93ZWxsLCBib29sIGVuYWJsZSkKPiA+ID4gPiAgewo+ID4gPiA+ICAJ ZW51bSBwdW5pdF9wb3dlcl93ZWxsIHBvd2VyX3dlbGxfaWQgPSBwb3dlcl93ZWxsLT5kYXRhOwo+ ID4gPiA+ICAJdTMyIG1hc2s7Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMK PiA+ID4gPiBpbmRleCAyYTcyYmFiLi5mMWFiZDJkIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPiA+ID4gPiBAQCAtMzYzLDYgKzM2Myw5IEBAIHN0YXRp YyB2b2lkIGludGVsX3VuY29yZV9mb3JjZXdha2VfcmVzZXQoc3RydWN0IGRybV9kZXZpY2UgKmRl diwgYm9vbCByZXN0b3JlKQo+ID4gPiA+ICAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmZGV2X3By aXYtPnVuY29yZS5sb2NrLCBpcnFmbGFncyk7Cj4gPiA+ID4gIH0KPiA+ID4gPiAgCj4gPiA+ID4g K3ZvaWQgdmx2X3NldF9wb3dlcl93ZWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+ID4gPiArCQkJc3RydWN0IGk5MTVfcG93ZXJfd2VsbCAqcG93ZXJfd2VsbCwgYm9vbCBl bmFibGUpOwo+ID4gPiA+ICsKPiA+ID4gPiAgdm9pZCBpbnRlbF91bmNvcmVfZWFybHlfc2FuaXRp emUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ID4gPiAgewo+ID4gPiA+ICAJc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+ID4gPiBAQCAt MzgxLDYgKzM4NCwyMiBAQCB2b2lkIGludGVsX3VuY29yZV9lYXJseV9zYW5pdGl6ZShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2KQo+ID4gPiA+ICAJCURSTV9JTkZPKCJGb3VuZCAlenVNQiBvZiBlTExD XG4iLCBkZXZfcHJpdi0+ZWxsY19zaXplKTsKPiA+ID4gPiAgCX0KPiA+ID4gPiAgCj4gPiA+ID4g KwkvKgo+ID4gPiA+ICsJICogRnJvbSBWTFYyQTBfRFBfZURQX0hETUlfRFBJT19kcml2ZXJfdmJp b3Nfbm90ZXNfMTEuZG9jeDoKPiA+ID4gPiArCSAqIE5lZWQgdG8gYXNzZXJ0IGFuZCBkZS1hc3Nl cnQgUEhZIFNCIHJlc2V0IGJ5IGdhdGluZyB0aGUgY29tbW9uCj4gPiA+ID4gKwkgKiBsYW5lIHBv d2VyLCB0aGVuIHVuLWdhdGluZyBpdC4KPiA+ID4gPiArCSAqIFNpbXBseSB1bmdhdGluZyBpc24n dCBlbm91Z2ggdG8gcmVzZXQgdGhlIFBIWSBlbm91Z2ggdG8gZ2V0Cj4gPiA+ID4gKwkgKiBwb3J0 cyBhbmQgbGFuZXMgcnVubmluZy4KPiA+ID4gPiArCSAqLwo+ID4gPiA+ICsJaWYgKElTX1ZBTExF WVZJRVcoZGV2KSkgewo+ID4gPiA+ICsJCXN0cnVjdCBpOTE1X3Bvd2VyX3dlbGwgY21uX3dlbGwg PSB7Cj4gPiA+ID4gKwkJCS5kYXRhID0gUFVOSVRfUE9XRVJfV0VMTF9EUElPX0NNTl9CQwo+ID4g PiA+ICsJCX07Cj4gPiA+ID4gKwo+ID4gPiA+ICsJCXZsdl9zZXRfcG93ZXJfd2VsbChkZXZfcHJp diwgJmNtbl93ZWxsLCBmYWxzZSk7Cj4gPiA+ID4gKwkJdmx2X3NldF9wb3dlcl93ZWxsKGRldl9w cml2LCAmY21uX3dlbGwsIHRydWUpOwo+ID4gPiA+ICsJfQo+ID4gPiAKPiA+ID4gUmVsYXRpb25z aGlwIHdpdGggaW50ZWxfcmVzZXRfZHBpbz8gU2hvdWxkIHdlIG1vdmUgdGhpcyBiaXQgb2YgY29k ZSBvdmVyCj4gPiA+IHRoZXJlPyBJJ20gbG9zdCBpbiB0aGlzIG1hemUgb2Yga2ljay1tZS1oYXJk ZXIgcGF0Y2hlcyBmb3IgYnl0IGRwaW8gLi4uCj4gPiAKPiA+IFRoYXQgaGFwcGVucyB0b28gbGF0 ZS4gIFRoaXMgd2lsbCBjbG9iYmVyIHJlZ2lzdGVyIHN0YXRlLCB3aGVyZWFzIHRoZQo+ID4gRFBJ TyByZXNldCBqdXN0IHJlc2V0cyB0aGUgaW50ZXJmYWNlIGJldHdlZW4gdGhlIHBoeSBhbmQgdGhl IGRpc3BsYXkuCj4gCj4gQXMgYSBjbGFyaWZpY2F0aW9uIHRvIHRoZSBjbW5yZXNldCB0aGluZywg d2UgbmV2ZXIgYWN0dWFsbHkgYXNzZXJ0Cj4gdGhhdCBzaWduYWwsIHdlIGp1c3QgZGVhc3NlcnQg aXQuIFRoZSBpZGVhIGJlaW5nIHRoYXQgaXQgc2hvdWxkIGJlCj4gYXNzZXJ0ZWQgYnkgZGVmYXVs dCB3aGVuIHRoaW5ncyBnZXQgcG93ZXJlZCBvbi4gQnV0IEkgd29uZGVyIGlmIHdlCj4gc2hvdWxk IGFzc2VydCBpdCBiZWZvcmUgc3VzcGVuZGluZyBhbnl3YXkuCgpBbmQgbWF5YmUgZG8gYSB3cml0 ZSBvZiAwIHRoZW4gMSBvbiByZXN1bWUgdG9vLiAgVGhhdCdzIHdoYXQgV2luZG93cwpkb2VzIGFm YWlrLgoKPiBPaCBhbmQgSSB0aGluayBpZiB3ZSBwb3dlciBnYXRlIHRoZSBjbW5sYW5lIHdlIHdv dWxkIG5lZWQgdG8KPiBhc3NlcnQvZGVhc3NlcnQgY21ucmVzZXQgYXJvdW5kIGl0LiBJbiBzb21l IENIViBkb2MgSSBzZWUgYSBub3RlCj4gdGhhdCBzaWRlIHJlc2V0IG11c3QgYmUgZGVhc3NlcnRl ZCBiZWZvcmUgY21ucmVzZXQuIFRoZSB0aW1pbmcKPiBkaWFncmFtcyBpbiBWTFYgZG9jcyBzZWVt IHRvIGhhdmUgdGhhdCBvcmRlciBhcyB3ZWxsLiBTbyB1bmxlc3MKPiB0aGVyZSdzIHNvbWUgaW50 ZXJuYWwgbG9naWMgd2hpY2ggaG9sZCBjbW5yZXNldCBhc3NlcnRlZCBmb3IgdGhlCj4gcmVxdWly ZWQgdGltZSwgd2Ugc2hvdWxkIGRvIGl0IGJ5IGhhbmQuCgpZZWFoIHdvdWxkIGJlIGdvb2QgdG8g ZG8gdGhhdCB0byBiZSBvbiB0aGUgc2FmZSBzaWRlLgoKPiBPaCBhbmQgdGhlcmUncyBhbm90aGVy IGludGVyc3RpbmcgbG9va2luZyBub3RlOgo+IAo+ICJOT1RFMSA6IENvbW1vbiBsYW5lIHJlc2V0 IG11c3Qgbm90IGJlIGRlLWFzc2VydGVkIHVudGlsIFJFRkNMSyB0byBQTEwgaXMKPiAgZW5hYmxl ZCBieSBpX3BsbCpyZWZjbGtidWZlbiBhbmQgdGhlIGNsb2NrIGlzIHJ1bm5pbmcgYW5kIHN0YWJs ZSIKPiAKPiBJIGd1ZXNzIHdlIG1hbmFnZWQgdG8gZm9sbG93IHRoYXQgYnkgYWNjaWRlbnQgc2lu Y2Ugd2UgZW5hYmxlIHRoZQo+IHJlZmNsb2NrIGZvciBEUExMQiBmb3IgdGhlIGhvdHBsdWcgd29y a2Fyb3VuZC4gQnV0IHBlcmhhcHMgd2Ugc2hvdWxkCj4gZW5hYmxlIHRoZSByZWZjbGsgZm9yIGFs bCBQTExzIGp1c3QgdG8gYmUgc3VyZS4KClllYWggdGhhdCBzaG91bGRuJ3QgaHVydC4gIEluIHRh bGtpbmcgd2l0aCB0aGUgUEhZIGd1eXMsIHRoZSBjbW5yZXNldApkZS1hc3NlcnQgd2lsbCBjYXVz ZSB0aGUgUEhZIHRvIHJlLWNhbGlicmF0ZSwgYW5kIGFueSBQTEwgc2V0dGluZ3MKd29uJ3QgdGFr ZSBlZmZlY3QgdW50aWwgdGhhdCdzIGNvbXBsZXRlLiAgVGhleSB3aWxsIGhvd2V2ZXIgYmUgbGF0 Y2hlZAomIHBlbmRlZCBpbnRvIHRoZSBkaXNwbGF5LCBzbyBpdCdzIHNhZmUgdG8gd3JpdGUgdGhl bSBiZWZvcmUsIGJ1dAp0aGV5J2xsIHRha2UgbG9uZ2VyIHRvIGxvY2sgdGhlIGZpcnN0IHRpbWUu CgotLSAKSmVzc2UgQmFybmVzLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=