Re: [PATCH 0/3] Two new drm crtc properties

Goel, Akash
2014-03-22T04:29:58Z

Actually since the Panel fitter is at the Pipe level and also the PIPESRC register, this has been exposed through crtc property. But with crtc also, it is kind of associated with primary planes only.

Best Regards
Akash

-----Original Message-----
From: daniel.vetter@ffwll.ch [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
Sent: Saturday, March 22, 2014 1:24 AM
To: Goel, Akash
Cc: intel-gfx
Subject: Re: [Intel-gfx] [PATCH 0/3] Two new drm crtc properties

On Mon, Mar 10, 2014 at 6:14 AM, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Mon, Mar 10, 2014 at 10:40:50AM +0530, akash.goel@intel.com wrote:
>> From: Akash Goel <akash.goel@intel.com>
>>
>> Added 2 new drm crtc properties. One property provides control to
>> vary the PIPESRC value. With this the size of Pipe's output or Panel
>> fitter input can be varied.
>> The other property provides control to vary the size of horizontal &
>> vertical borders. With this the size of the Panel fitter output or
>> display window could be controlled.
>>
>> Akash Goel (3):
>> drm/i915: Initialized 'set_property' fn pointer field of
>> intel_crtc_funcs structure
>> drm/i915: New drm crtc property for varying the Pipe Src size
>> drm/i915: New drm crtc property for varying the size of borders
>
> Hm, where are the igt testcases for this feature? I expect some fun
> interactions at least with pageflips/modesets vs. setting this. The
> vblank timing code should be fine, since it always deals with adjusted
> timings.

Follow-up from my side ... could we just expose this through primary planes, or is the damn panel fitter at the wrong spot in the pipeline?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch