From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/plane_helper: don't disable plane in destroy function
Date: Fri, 11 Apr 2014 15:39:19 +0200
Message-ID: <20140411133917.GA14885@ulmo>
References: <1397218330-28368-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2076644795=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1397218330-28368-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Thierry Reding <treding@nvidia.com>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org


--===============2076644795==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="OXfL5xGRrasGEqWY"
Content-Disposition: inline


--OXfL5xGRrasGEqWY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 11, 2014 at 02:12:10PM +0200, Daniel Vetter wrote:
> By the time drm_mode_config_cleanup calls this all the hw state should
> be cleaned up already - we even have a WARN right before calling
> plane->destroy callbacks asserting that all framebuffers are gone.
>=20
> So trying to disable things harder is a bit a bug. Caught by Thierry
> since it resulted in some mode_config.mutex locking backtraces.
>=20
> Cc: Thierry Reding <treding@nvidia.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_plane_helper.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>
Tested-by: Thierry Reding <treding@nvidia.com>

--OXfL5xGRrasGEqWY
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTR/CFAAoJEN0jrNd/PrOhhNYP/R5QiVPaKQr6NBHncvsSPQk1
c+6mgWTquO3YvgAAGn29fu3gu7boxIzY/io8oY57oBbPhYRtZF137Zc6myaI+MuZ
XwJ+jxkzD+TXpSrN3bhok926VYtwdJkdGkaxmN1nUVSiYvpYzNqjgyi3hgCvZxrg
gnPFlnkJFgOOrcoleZjH7QI74s5ebwKPj8kiXOJ1w7G4IbuykZZIX+RO3/mCbZF0
8DU6MxX0Yf9aX1JipU3AKcDWVzNdTfSJdm+k4oaczsUUEx1td03ox00nNWdMxrn8
bEyNpGY7zUnxPQMKnL8DOW76NaEg5BMOKDGgqKRK6uI825ZBmoH+4NLgxjeq3WYn
YRicNWrQEdfEsM1MB80g9GDoppIj2kZGU2sWV5NEk4SI1no6AsVWc6ZsAKIGyYa/
/cx2LuYwv8Z3CwW/GD3yj8CpdzIgLRq3nJjckG5KV4bXi/FVvqZ05KhEWVQfxSwE
c0amZRmlxA3zYn8pVVX4VNbFUSaN1oK70CWeYkSc6Zc3V3g3XWL5ldFSD+vdHHTx
f/9E6TPCcaPibra/R/YK3jSHcrlz+e1sGgEGQ+8/+bczIBocBxCem3SJ6x1rkBKW
p56UlhR2vBMCua1GFbLJbtGRzI0UQ3oi2PkmBr6Tbx2CG9sm61OdjYAdDWh+d6PC
y2nZcHa0MpwY4Nva+g/l
=XNsf
-----END PGP SIGNATURE-----

--OXfL5xGRrasGEqWY--

--===============2076644795==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

--===============2076644795==--