From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] tests/kms_flip_tiling: Fixes
Date: Fri, 11 Apr 2014 16:28:14 +0200
Message-ID: <20140411142814.GL9262@phenom.ffwll.local>
References: <1397225868-11238-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53])
 by gabe.freedesktop.org (Postfix) with ESMTP id 505496EDD4
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Apr 2014 07:28:17 -0700 (PDT)
Received: by mail-ee0-f53.google.com with SMTP id b57so4186264eek.40
 for <intel-gfx@lists.freedesktop.org>; Fri, 11 Apr 2014 07:28:16 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1397225868-11238-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 11, 2014 at 04:17:48PM +0200, Daniel Vetter wrote:
> - Wrap up testcase correctly into the magic code block.
> - Put local variables out of the longjmp danger zone.
> 
> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Ander, quick one for process: Please submit igt patches to the mailing
list so that they don't get lost in bugzilla.

And thanks a lot for the testcase.
-Daniel

> ---
>  tests/kms_flip_tiling.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/kms_flip_tiling.c b/tests/kms_flip_tiling.c
> index e70609d52e78..ca20ad96bc35 100644
> --- a/tests/kms_flip_tiling.c
> +++ b/tests/kms_flip_tiling.c
> @@ -119,11 +119,10 @@ test_flip_changes_tiling(data_t *data, igt_output_t *output)
>  }
>  
>  static data_t data;
> +igt_output_t *output;
>  
>  igt_main
>  {
> -	igt_output_t *output;
> -
>  	igt_skip_on_simulation();
>  
>  	igt_fixture {
> @@ -135,10 +134,10 @@ igt_main
>  		igt_display_init(&data.display, data.drm_fd);
>  	}
>  
> -	igt_subtest_f("flip-changes-tiling");
> -
> -	for_each_connected_output(&data.display, output)
> -		test_flip_changes_tiling(&data, output);
> +	igt_subtest_f("flip-changes-tiling") {
> +		for_each_connected_output(&data.display, output)
> +			test_flip_changes_tiling(&data, output);
> +	}
>  
>  	igt_fixture {
>  		igt_display_fini(&data.display);
> -- 
> 1.8.5.2
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch