From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/bdw: Use timeout mode for RC6 on bdw
Date: Fri, 11 Apr 2014 22:56:17 -0700 [thread overview]
Message-ID: <20140412055616.GA14982@bwidawsk.net> (raw)
In-Reply-To: <20140411090038.GY9262@phenom.ffwll.local>
On Fri, Apr 11, 2014 at 11:00:38AM +0200, Daniel Vetter wrote:
> On Thu, Apr 10, 2014 at 08:29:55PM +0000, O'Rourke, Tom wrote:
> > >> > Higher RC6 residency is observed using timeout mode instead of EI
> > >> > mode. This applies to Broadwell only.
> > >> > The difference is particularly noticeable with video playback.
> > >> >
> > >> > Issue: VIZ-3778
> > >> > Change-Id: I62bb12e21caf19651034826b45cde7f73a80938d
> > >> > Signed-off-by: Tom O'Rourke <Tom.O'Rourke@intel.com>
> > >>
> > >> How recent a nightly branch have you used to obtain these results?
> > >> Chris just fixed some serious bugs in the gpu booster logic which
> > >> would have affected all intermediate workloads.
> > >> -Daniel
> > >
> > >He must not be using nightly if he has any BDW RC6 residency at all.
> > >
> > [TOR:] Ben is correct. I was testing mostly with a kernel for Android.
> > I also tested with Ben's broadwell branch and saw similar improvement.
>
> Ok I think it'd be good to have this when we actually merge/enable the
> final pieces of the bdw rc6 code. Can you please work together with Ben to
> make sure this patch isn't lost?
>
> Or who is shepherding bdw rc6 nowadays?
> -Daniel
Locally, people are still using my RC6 "workaround." We're waiting on
Mika at the moment. I am going to merge this patch to my
bdw-rc6/broadwell branches.
I think it would be great to get a little more detail under what
circumstances this improves residency. We can discuss that internally.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-04-12 5:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 18:44 [PATCH] drm/i915/bdw: Use timeout mode for RC6 on bdw Tom O'Rourke
2014-04-09 20:02 ` Daniel Vetter
2014-04-09 22:36 ` Ben Widawsky
2014-04-10 20:29 ` O'Rourke, Tom
2014-04-11 9:00 ` Daniel Vetter
2014-04-12 5:56 ` Ben Widawsky [this message]
2014-04-30 5:31 ` Ben Widawsky
2014-04-30 20:34 ` Kristen Carlson Accardi
2014-04-30 20:41 ` Ben Widawsky
2014-04-30 21:03 ` Imre Deak
2014-04-30 21:14 ` Kristen Carlson Accardi
2014-05-01 22:35 ` Ben Widawsky
2014-05-30 23:30 ` O'Rourke, Tom
2014-06-02 8:26 ` Daniel Vetter
2014-06-02 21:51 ` O'Rourke, Tom
2014-06-03 7:38 ` Daniel Vetter
2014-06-09 20:50 ` O'Rourke, Tom
2014-06-20 16:42 ` Ben Widawsky
2014-06-20 19:01 ` O'Rourke, Tom
2014-07-01 1:19 ` O'Rourke, Tom
2014-07-02 11:06 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140412055616.GA14982@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox