From: Daniel Vetter <daniel@ffwll.ch>
To: "Kumar, Shobhit" <shobhit.kumar@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Daniel Vetter <daniel.vetter@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v3] drm/i915: Add parsing support for new MIPI blocks in VBT
Date: Mon, 14 Apr 2014 11:05:32 +0200 [thread overview]
Message-ID: <20140414075927.GA1023@phenom.ffwll.local> (raw)
In-Reply-To: <534B9443.7020609@intel.com>
On Mon, Apr 14, 2014 at 01:24:43PM +0530, Kumar, Shobhit wrote:
> On 4/14/2014 12:32 PM, Daniel Vetter wrote:
> >On Mon, Apr 14, 2014 at 11:00:34AM +0530, Shobhit Kumar wrote:
> >>The parser extracts the config block(#52) and sequence(#53) data
> >>and store in private data structures.
> >>
> >>v2: Address review comments by Jani
> >> - adjust code for the structure changes for bdb_mipi_config
> >> - add boundry and buffer overflow checks as suggested
> >> - use kmemdup instead of kmalloc and memcpy
> >>
> >>v3: More strict check while parsing VBT
> >> - Ensure that at anytime we do not go beyond sequence block
> >> while parsing
> >> - On unknown element fail the whole parsing
> >>
> >>v4: Style changes and spell check mostly as suggested by Jani
> >>
> >>Signed-off-by: Shobhit Kumar <shobhit.kumar@intel.com>
> >>Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> >
> >I didn't spot Jani's r-b tag in earlier mails, was that done off-list?
>
> Yeah, was reviewed along with the other DSI patchset you merged, sorry about
> that. But then some patches needed internal review while they were being
> approved for up-streaming to save time. And this one was related to the
> other panel driver patches which I published today so got stuck with them.
> Sorry about that.
Ok, pulled it in. checkpatch complained a few times about assignments in
if conditions, and I tend to agree. Can you please follow up with a
cleanup patch? Also it looks like assignment operators could be used.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-14 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 11:16 [v2 0/2] Support for new MIPI Blocks in VBT Shobhit Kumar
2014-02-20 11:16 ` [v2 1/2] drm/i915: Update VBT data structures to have MIPI block enhancements Shobhit Kumar
2014-02-27 14:48 ` Jani Nikula
2014-02-28 5:25 ` Shobhit Kumar
2014-02-28 5:48 ` [PATCH] " Shobhit Kumar
2014-03-05 12:52 ` Daniel Vetter
2014-02-20 11:16 ` [v2 2/2] drm/i915: Add parsing support for new MIPI blocks in VBT Shobhit Kumar
2014-02-28 12:34 ` Jani Nikula
2014-04-14 5:30 ` [PATCH v3] " Shobhit Kumar
2014-04-14 7:02 ` Daniel Vetter
2014-04-14 7:54 ` Kumar, Shobhit
2014-04-14 9:05 ` Daniel Vetter [this message]
2014-04-14 9:55 ` Kumar, Shobhit
2014-04-15 8:24 ` [PATCH] drm/i915: Code cleanup patch to fix checkpatch errors Shobhit Kumar
2014-04-15 19:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414075927.GA1023@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=shobhit.kumar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox