From: Daniel Vetter <daniel@ffwll.ch>
To: "Volkin, Bradley D" <bradley.d.volkin@intel.com>
Cc: "Intel-gfx@lists.freedesktop.org" <Intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact
Date: Tue, 22 Apr 2014 20:59:23 +0200 [thread overview]
Message-ID: <20140422185923.GY10722@phenom.ffwll.local> (raw)
In-Reply-To: <20140417231846.GB7521@bdvolkin-ubuntu-desktop>
On Thu, Apr 17, 2014 at 04:18:46PM -0700, Volkin, Bradley D wrote:
> On Wed, Mar 19, 2014 at 04:13:06AM -0700, Tvrtko Ursulin wrote:
> > + bo_ptr = (char *)(((unsigned long)ptr + (PAGE_SIZE - 1))
> > + & ~(PAGE_SIZE - 1));
>
> You might add an ALIGN macro in this file or a suitable header. A couple of
> .c files in lib/ individually define one already.
lib/drmtest.h (with the gtkdoc for it include) is the current grab-bag for
such random useful pieces. We already have an ARRAY_SIZE in there.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-22 18:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 16:17 [PATCH 0/3] tests: New userptr test case Tvrtko Ursulin
2014-02-26 16:17 ` [PATCH 1/3] tests/gem_userptr_blits: Expanded userptr test cases Tvrtko Ursulin
2014-03-05 14:48 ` Chris Wilson
2014-03-12 13:21 ` Tvrtko Ursulin
2014-02-26 16:17 ` [PATCH 2/3] tests/gem_vmap_blits: Remove obsolete test case Tvrtko Ursulin
2014-02-26 16:17 ` [PATCH 3/3] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact Tvrtko Ursulin
2014-03-19 11:13 ` [PATCH 0/3] tests: New userptr test case Tvrtko Ursulin
2014-03-19 11:13 ` [PATCH 1/3] tests/gem_userptr_blits: Expanded userptr test cases Tvrtko Ursulin
2014-04-18 17:10 ` Volkin, Bradley D
2014-04-23 13:33 ` Tvrtko Ursulin
2014-04-23 15:32 ` Volkin, Bradley D
2014-04-23 17:53 ` Daniel Vetter
2014-03-19 11:13 ` [PATCH 2/3] tests/gem_vmap_blits: Remove obsolete test case Tvrtko Ursulin
2014-04-17 23:20 ` Volkin, Bradley D
2014-03-19 11:13 ` [PATCH 3/3] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact Tvrtko Ursulin
2014-04-17 23:18 ` Volkin, Bradley D
2014-04-22 18:59 ` Daniel Vetter [this message]
2014-04-23 13:28 ` Tvrtko Ursulin
2014-04-23 15:24 ` Volkin, Bradley D
2014-04-23 16:38 ` [PATCH 1/3] tests/gem_userptr_blits: Expanded userptr test cases Tvrtko Ursulin
2014-04-23 16:38 ` [PATCH 2/3] tests/gem_vmap_blits: Remove obsolete test case Tvrtko Ursulin
2014-04-23 17:12 ` Volkin, Bradley D
2014-04-23 16:38 ` [PATCH 3/3] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact Tvrtko Ursulin
2014-04-23 17:17 ` Volkin, Bradley D
2014-04-24 9:08 ` Tvrtko Ursulin
2014-04-23 17:24 ` [PATCH 1/3] tests/gem_userptr_blits: Expanded userptr test cases Volkin, Bradley D
2014-04-24 9:07 ` [PATCH 3/3] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact Tvrtko Ursulin
2014-04-24 16:07 ` Volkin, Bradley D
-- strict thread matches above, loose matches on Subject: below --
2014-04-25 14:42 [PATCH 1/3] tests/gem_userptr_blits: Expanded userptr test cases Tvrtko Ursulin
2014-04-25 14:42 ` [PATCH 3/3] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422185923.GY10722@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=bradley.d.volkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox