From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/4] drm/i915: remove useless runtime PM get call Date: Wed, 23 Apr 2014 12:52:42 +0300 Message-ID: <20140423095242.GG18465@intel.com> References: <20140411132123.GH9262@phenom.ffwll.local> <1398207345-1865-1-git-send-email-przanoni@gmail.com> <1398207345-1865-4-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id BC2AE6EA3F for ; Wed, 23 Apr 2014 02:53:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1398207345-1865-4-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 22, 2014 at 07:55:45PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > = > We already call intel_dp_power_get, which will get a power domain, and > every power domain should get a runtime PM reference, which will wake > up the machine. intel_crt_detect() could use the same treatment > = > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_dp.c | 3 --- > 1 file changed, 3 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel= _dp.c > index a25f708..a0b1cda 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -3171,11 +3171,9 @@ intel_dp_detect(struct drm_connector *connector, b= ool force) > struct intel_digital_port *intel_dig_port =3D dp_to_dig_port(intel_dp); > struct intel_encoder *intel_encoder =3D &intel_dig_port->base; > struct drm_device *dev =3D connector->dev; > - struct drm_i915_private *dev_priv =3D dev->dev_private; > enum drm_connector_status status; > struct edid *edid =3D NULL; > = > - intel_runtime_pm_get(dev_priv); > intel_dp_power_get(intel_encoder); > = > DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n", > @@ -3209,7 +3207,6 @@ intel_dp_detect(struct drm_connector *connector, bo= ol force) > = > out: > intel_dp_power_put(intel_encoder); > - intel_runtime_pm_put(dev_priv); > = > return status; > } > -- = > 1.9.0 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC