Re: [PATCH v2 07/24] drm/i915: Remove useless checks from primary enable/disable

Ville Syrjälä
2014-04-30T11:40:14Z

On Wed, Apr 30, 2014 at 12:28:25PM +0100, Chris Wilson wrote:
> On Mon, Apr 28, 2014 at 03:53:25PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > We won't be calling intel_enable_primary_plane() or
> > intel_disable_primary_plane() with the primary plane in the
> > wrong state. So remove the useless DISPLAY_PLANE_ENABLE checks.
>
> Oh, really? That sounds very, very confident. However,
> haswell_get_pipe_config() disagrees with you.

Are you saying you have a machine where the BIOS enables the pipe
but not the plane? Otherwise I don't know what get_pipe_config() has to
do with this.

--
Ville Syrjälä
Intel OTC