Re: [PATCH v2 07/24] drm/i915: Remove useless checks from primary enable/disable

Daniel Vetter
2014-04-30T12:34:24Z

On Wed, Apr 30, 2014 at 12:43:18PM +0100, Chris Wilson wrote:
> On Wed, Apr 30, 2014 at 02:40:10PM +0300, Ville Syrjälä wrote:
> > On Wed, Apr 30, 2014 at 12:28:25PM +0100, Chris Wilson wrote:
> > > On Mon, Apr 28, 2014 at 03:53:25PM +0300, ville.syrjala@linux.intel.com wrote:
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > We won't be calling intel_enable_primary_plane() or
> > > > intel_disable_primary_plane() with the primary plane in the
> > > > wrong state. So remove the useless DISPLAY_PLANE_ENABLE checks.
> > >
> > > Oh, really? That sounds very, very confident. However,
> > > haswell_get_pipe_config() disagrees with you.
> >
> > Are you saying you have a machine where the BIOS enables the pipe
> > but not the plane? Otherwise I don't know what get_pipe_config() has to
> > do with this.
>
> Yes.

I guess we need to shovel the plane related state out of the pipe_config
into the mythical plane_config ... One issue atm is that we use the plane
bpp to decide what bpp the pipe should be driven at. And the dither
settings for it. Especially for dithering I'm a bit unclear whether we can
change that while the pipe is enabled or not ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch