From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 4/4] drm/i915: remove useless runtime PM get calls Date: Thu, 24 Apr 2014 17:05:21 +0300 Message-ID: <20140424140521.GQ18465@intel.com> References: <20140423095242.GG18465@intel.com> <1398347456-2523-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id E185489081 for ; Thu, 24 Apr 2014 07:06:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1398347456-2523-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 24, 2014 at 10:50:56AM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > = > We already call intel_dp_power_get, which will get a power domain, and ^^^^^^^^^^^^^^^^^^ Commit message needs a small fix. Otherwise looks good. Reviewed-by: Ville Syrj=E4l=E4 > every power domain should get a runtime PM reference, which will wake > up the machine. > = > v2: - Also touch intel_crt_detect() (Ville). > = > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_crt.c | 4 ---- > drivers/gpu/drm/i915/intel_dp.c | 5 ----- > 2 files changed, 9 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/intel_crt.c b/drivers/gpu/drm/i915/inte= l_crt.c > index aa5a3dc..4c673d0 100644 > --- a/drivers/gpu/drm/i915/intel_crt.c > +++ b/drivers/gpu/drm/i915/intel_crt.c > @@ -646,8 +646,6 @@ intel_crt_detect(struct drm_connector *connector, boo= l force) > enum drm_connector_status status; > struct intel_load_detect_pipe tmp; > = > - intel_runtime_pm_get(dev_priv); > - > DRM_DEBUG_KMS("[CONNECTOR:%d:%s] force=3D%d\n", > connector->base.id, drm_get_connector_name(connector), > force); > @@ -699,8 +697,6 @@ intel_crt_detect(struct drm_connector *connector, boo= l force) > = > out: > intel_display_power_put(dev_priv, power_domain); > - intel_runtime_pm_put(dev_priv); > - > return status; > } > = > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel= _dp.c > index 66d202c..104998e 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -3155,8 +3155,6 @@ intel_dp_detect(struct drm_connector *connector, bo= ol force) > enum intel_display_power_domain power_domain; > struct edid *edid =3D NULL; > = > - intel_runtime_pm_get(dev_priv); > - > power_domain =3D intel_display_port_power_domain(intel_encoder); > intel_display_power_get(dev_priv, power_domain); > = > @@ -3191,9 +3189,6 @@ intel_dp_detect(struct drm_connector *connector, bo= ol force) > = > out: > intel_display_power_put(dev_priv, power_domain); > - > - intel_runtime_pm_put(dev_priv); > - > return status; > } > = > -- = > 1.9.0 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- = Ville Syrj=E4l=E4 Intel OTC