From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@gmail.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 00/14] drm-intel-collector - update
Date: Fri, 25 Apr 2014 12:07:48 +0200 [thread overview]
Message-ID: <20140425100748.GR26374@phenom.ffwll.local> (raw)
In-Reply-To: <20140425092445.GP31221@nuc-i3427.alporthouse.com>
On Fri, Apr 25, 2014 at 10:24:45AM +0100, Chris Wilson wrote:
> On Fri, Apr 25, 2014 at 11:04:22AM +0200, Daniel Vetter wrote:
> > > Patch drm/i915: Upgrade execbuffer fail after resume failure to EIO - Reviewer:
> >
> > Do we still need this on top of what I've merged. Chris?
>
> Yes. We can still start the device without initializing all of the
> available rings and so hit this before we fail with an EIO.
Hm, so we'd need to adjust the commit message a bit since with
commit 5582e8c3c49150c0e7398688b5ed167d6c3d44fd
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date: Wed Apr 9 09:19:41 2014 +0100
drm/i915: Preserve ring buffers objects across resume
this is just a driver load issue and no longer a resume issue. Or do I
miss something else?
Or should we frob the ring init some more and simply leave the ring->obj
hanging around, eat the -EIO and wedge the gpu?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-25 10:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-18 21:04 [PATCH 00/14] drm-intel-collector - update Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 01/14] drm/i915: Bring UP Power Wells before disabling RC6 Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 02/14] drm/i915: Add support for stealing purgable stolen pages Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 03/14] drm/i915: Do not allow a pending forcewake put to unbalance across reset Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 04/14] drm/i915: Don't save/restore RS when not used Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 05/14] drm/i915: add support for Z-order of planes Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 06/14] drm/i915: Validate VBT header before trusting it Rodrigo Vivi
2014-04-24 15:52 ` Kumar, Shobhit
2014-04-25 8:02 ` Daniel Vetter
2014-04-25 8:24 ` Kumar, Shobhit
2014-04-25 9:12 ` Daniel Vetter
2014-04-25 9:28 ` Chris Wilson
2014-04-25 11:24 ` Kumar, Shobhit
2014-04-18 21:04 ` [PATCH 07/14] drm/i915: Validate BDB section before reading Rodrigo Vivi
2014-04-24 15:53 ` Kumar, Shobhit
2014-04-25 8:03 ` Daniel Vetter
2014-04-18 21:04 ` [PATCH 08/14] drm/i915: Upgrade execbuffer fail after resume failure to EIO Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 09/14] drm/i915: Add property to set HDMI aspect ratio Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 10/14] drm/i915: Prevent context obj from being corrupted Rodrigo Vivi
2014-04-18 21:04 ` [PATCH 11/14] drm/i915/bdw: Add WT caching ability Rodrigo Vivi
2014-04-28 16:19 ` Volkin, Bradley D
2014-04-18 21:04 ` [PATCH 12/14] drm/i915/bdw: enable eDRAM Rodrigo Vivi
2014-04-28 16:27 ` Volkin, Bradley D
2014-04-18 21:04 ` [PATCH 13/14] drm/i915/bdw: Disable idle DOP clock gating Rodrigo Vivi
2014-04-28 16:37 ` Volkin, Bradley D
2014-04-29 8:50 ` Daniel Vetter
2014-04-18 21:04 ` [PATCH 14/14] drm/i915: honour forced connector modes Rodrigo Vivi
2014-04-25 9:04 ` [PATCH 00/14] drm-intel-collector - update Daniel Vetter
2014-04-25 9:24 ` Chris Wilson
2014-04-25 10:07 ` Daniel Vetter [this message]
2014-04-25 10:19 ` Chris Wilson
2014-04-25 10:31 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425100748.GR26374@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox