From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/14] drm-intel-collector - update Date: Fri, 25 Apr 2014 12:07:48 +0200 Message-ID: <20140425100748.GR26374@phenom.ffwll.local> References: <1397855070-4480-1-git-send-email-rodrigo.vivi@gmail.com> <20140425092445.GP31221@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 530926EE0E for ; Fri, 25 Apr 2014 03:07:53 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id d17so2662013eek.1 for ; Fri, 25 Apr 2014 03:07:52 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140425092445.GP31221@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , Rodrigo Vivi , intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 25, 2014 at 10:24:45AM +0100, Chris Wilson wrote: > On Fri, Apr 25, 2014 at 11:04:22AM +0200, Daniel Vetter wrote: > > > Patch drm/i915: Upgrade execbuffer fail after resume failure to EIO - Reviewer: > > > > Do we still need this on top of what I've merged. Chris? > > Yes. We can still start the device without initializing all of the > available rings and so hit this before we fail with an EIO. Hm, so we'd need to adjust the commit message a bit since with commit 5582e8c3c49150c0e7398688b5ed167d6c3d44fd Author: Chris Wilson Date: Wed Apr 9 09:19:41 2014 +0100 drm/i915: Preserve ring buffers objects across resume this is just a driver load issue and no longer a resume issue. Or do I miss something else? Or should we frob the ring init some more and simply leave the ring->obj hanging around, eat the -EIO and wedge the gpu? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch