Re: [PATCH i-g-t v2 0/8] kms_cursor_crc enhancements

Daniel Vetter
2014-04-25T14:07:53Z

On Fri, Apr 25, 2014 at 04:27:02PM +0300, Ville Syrjälä wrote:
> On Thu, Apr 10, 2014 at 03:08:04PM +0300, Antti Koskipaa wrote:
> > This patch series enhances the cursor test to actually be useful.
> >
> > The old "black transparent cursor on black background" tests are
> > replaced with a visible cursor and the framework is changed to
> > be more flexible and extendable. This way cursor rotation tests
> > can be added with ease in the future.
> >
> > Also adds a couple more tests to the current set.
> >
> > v2:
> > - reinstate "go nuts" -test
> > - Add background picture for better test coverage
> >
> > Antti Koskipaa (8):
> > kms_cursor_crc: Remove some test cases and change cursor to color
> > kms_cursor_crc: Move cursor enable and disable calls where they belong
> > kms_cursor_crc: Use a function pointer to call test
> > kms_cursor_crc: Separate onscreen and offscreen tests
> > kms_cursor_crc: Add reference software rendering
> > kms_cursor_crc: Add moving cursor test
> > kms_cursor_crc: Add random cursor placement test
> > kms_cursor_crc: Add background picture
>
> I pushed the lot, and fixed the small issue in 2/8 that I pointed out.
>
> I also pushed a pile of extra fixes, mainly to fix --list-subtests,
> and I also tried to fix my gen2 LVDS vs. pipe B issue, which I
> suppose is the same thing as this bug:
> https://bugs.freedesktop.org/show_bug.cgi?id=75131

This is a general issue with the current igt kms helper, and it's going to
bite us again with the chv 3 pipe support due to pipe restrictions on the
DP ports. I have a todo (and some patches) somewhere, but just didn't get
around to this yet :(

There's a few other issues with the high-level helpers like no sane
support to reset all the state - after the first test most subsequent ones
end up all skipping ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch