Re: [PATCH i-g-t v2 7/8] kms_cursor_crc: Add random cursor placement test

Ville Syrjälä
2014-04-23T11:04:40Z

On Thu, Apr 10, 2014 at 03:08:11PM +0300, Antti Koskipaa wrote:
> Signed-off-by: Antti Koskipaa <antti.koskipaa@linux.intel.com>
> ---
> tests/kms_cursor_crc.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index b2498a1..e00abf5 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -214,6 +214,18 @@ static void test_crc_sliding(test_data_t *test_data)
> }
> }
>
> +static void test_crc_random(test_data_t *test_data)
> +{
> + int i;
> +
> + /* Random cursor placement */
> + for (i = 0; i < 50; i++) {
> + int x = rand() % (test_data->screenw + test_data->curw * 2) - test_data->curw;
> + int y = rand() % (test_data->screenh + test_data->curh * 2) - test_data->curh;
> + do_single_test(test_data, x, y);
> + }
> +}

As this is not deterministic it would be nice if the test would print
out some of the test parameters on failure (cursor coordinates and size
at least). Otherwise there's no good way to analyze failures.

> +
> static bool prepare_crtc(test_data_t *test_data, igt_output_t *output,
> int cursor_w, int cursor_h)
> {
> @@ -359,6 +371,8 @@ static void run_test_generic(data_t *data, int cursor_max_size)
> run_test(data, test_crc_offscreen, cursor_size, cursor_size);
> igt_subtest_f("cursor-%s-sliding", c_size)
> run_test(data, test_crc_sliding, cursor_size, cursor_size);
> + igt_subtest_f("cursor-%s-random", c_size)
> + run_test(data, test_crc_random, cursor_size, cursor_size);
> }
>
> }
> --
> 1.8.3.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Ville Syrjälä
Intel OTC