From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [RFC] tests/gem_bo_falloc: New igt for testing
 gem_fallocate() ioctl
Date: Fri, 25 Apr 2014 16:11:26 +0200
Message-ID: <20140425141126.GV26374@phenom.ffwll.local>
References: <1398430232-2957-1-git-send-email-arun.siluvery@linux.intel.com>
 <20140425141010.GU26374@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f53.google.com (mail-ee0-f53.google.com [74.125.83.53])
 by gabe.freedesktop.org (Postfix) with ESMTP id 313986E0A0
 for <intel-gfx@lists.freedesktop.org>; Fri, 25 Apr 2014 07:11:31 -0700 (PDT)
Received: by mail-ee0-f53.google.com with SMTP id b57so2832670eek.26
 for <intel-gfx@lists.freedesktop.org>; Fri, 25 Apr 2014 07:11:30 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140425141010.GU26374@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: arun.siluvery@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 25, 2014 at 04:10:10PM +0200, Daniel Vetter wrote:
> On Fri, Apr 25, 2014 at 01:50:32PM +0100, arun.siluvery@linux.intel.com wrote:
> > +int main(int argc, char **argv)
> > +{
> > +	igt_subtest_init(argc, argv);
> > +
> > +	igt_fixture
> > +		fd = drm_open_any();
> > +
> > +	igt_subtest("gem_falloc arguments validation")
> > +		test_gem_falloc_arguments_validation(fd);
> 
> We tend to have no spaces in subtest names, please use dash '-' instead.
> space have a good chance to upset our tooling.

Also no need to repeat gem_falloc in each subtest, our tooling generates
an overall testcase name of "igt/$test_binary/$subtest_name". So adding
gem_falloc again is redundant.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch