From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 42/71] drm/i915/chv: Implement
 WaDisableSamplerPowerBypass for CHV
Date: Mon, 28 Apr 2014 11:23:11 +0300
Message-ID: <20140428082311.GW18465@intel.com>
References: <1397039349-10639-1-git-send-email-ville.syrjala@linux.intel.com>
 <1397039349-10639-43-git-send-email-ville.syrjala@linux.intel.com>
 <CA+gsUGTMXrXk2Ln3+HEhF_ytnuNZEAwKKGghGyc8bcU6MwuR5Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by gabe.freedesktop.org (Postfix) with ESMTP id E79BA6E628
 for <intel-gfx@lists.freedesktop.org>; Mon, 28 Apr 2014 01:23:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CA+gsUGTMXrXk2Ln3+HEhF_ytnuNZEAwKKGghGyc8bcU6MwuR5Q@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 25, 2014 at 05:55:38PM -0300, Paulo Zanoni wrote:
> 2014-04-09 7:28 GMT-03:00  <ville.syrjala@linux.intel.com>:
> > From: Rafael Barbalho <rafael.barbalho@intel.com>
> >
> > Cherryview also needs this WA.
> =

> At least on the chv_rebase tree, this WA is implemented for BDW but it
> is not documented as pre-prod only, and its name is not there. We
> should probably add a comment documenting the name and the fact that
> it is also pre-prod on BDW.

IIRC BDW will need it even on production steppings.

I think I have a patch somewhere that add the w/a note for BDW, but I guess
I didn't post it yet.

> =

> =

> >
> > Signed-off-by: Rafael Barbalho <rafael.barbalho@intel.com>
> > [vsyrjala: Looks like it's for pre-prodution hw only]
> > Signed-off-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/int=
el_pm.c
> > index 468fe37..60f876c 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -5405,6 +5405,10 @@ static void cherryview_init_clock_gating(struct =
drm_device *dev)
> >         /* WaDisableSDEUnitClockGating:chv */
> >         I915_WRITE(GEN8_UCGCTL6, I915_READ(GEN8_UCGCTL6) |
> >                    GEN8_SDEUNIT_CLOCK_GATE_DISABLE);
> > +
> > +       /* WaDisableSamplerPowerBypass:chv (pre-production hw) */
> > +       I915_WRITE(HALF_SLICE_CHICKEN3,
> > +                  _MASKED_BIT_ENABLE(GEN8_SAMPLER_POWER_BYPASS_DIS));
> =

> I could not find information anywhere if this is the correct
> implementation. Can you please provide me pointers to the doc you
> used? The links on Collab seem broken.

Just w/a database + bspec are enough for this one.

> =

> Thanks,
> Paulo
> =

> >  }
> >
> >  static void g4x_init_clock_gating(struct drm_device *dev)
> > --
> > 1.8.3.2
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> =

> =

> =

> -- =

> Paulo Zanoni

-- =

Ville Syrj=E4l=E4
Intel OTC