From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Fix assert_plane warning during FDI link train
Date: Mon, 28 Apr 2014 15:43:57 +0200 [thread overview]
Message-ID: <20140428134357.GC32404@phenom.ffwll.local> (raw)
In-Reply-To: <1398453127-9947-1-git-send-email-ville.syrjala@linux.intel.com>
On Fri, Apr 25, 2014 at 10:12:07PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> assert_plane_enabled() is now triggering during FDI link train because
> we no longer enable planes that early.
>
> This problem got introduced in:
> commit a5c4d7bc187bd13bc11ac06bb4ea3a0d4001aa4d
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Date: Fri Mar 7 18:32:13 2014 +0200
>
> drm/i915: Disable/enable planes as the first/last thing during modeset on ILK+
>
> Just drop the assert since we shouldn't need planes for link training.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Queued for -next, thanks for the patch. I've spotted this in a QA report,
but afaik they didn't yet file a bug report.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-04-28 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 19:12 [PATCH] drm/i915: Fix assert_plane warning during FDI link train ville.syrjala
2014-04-28 13:43 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428134357.GC32404@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox