From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Fix assert_plane warning during FDI link train Date: Mon, 28 Apr 2014 15:43:57 +0200 Message-ID: <20140428134357.GC32404@phenom.ffwll.local> References: <1398453127-9947-1-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by gabe.freedesktop.org (Postfix) with ESMTP id B87286E672 for ; Mon, 28 Apr 2014 06:44:03 -0700 (PDT) Received: by mail-ee0-f54.google.com with SMTP id d49so4924517eek.13 for ; Mon, 28 Apr 2014 06:44:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1398453127-9947-1-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Apr 25, 2014 at 10:12:07PM +0300, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > assert_plane_enabled() is now triggering during FDI link train because > we no longer enable planes that early. > = > This problem got introduced in: > commit a5c4d7bc187bd13bc11ac06bb4ea3a0d4001aa4d > Author: Ville Syrj=E4l=E4 > Date: Fri Mar 7 18:32:13 2014 +0200 > = > drm/i915: Disable/enable planes as the first/last thing during modese= t on ILK+ > = > Just drop the assert since we shouldn't need planes for link training. > = > Signed-off-by: Ville Syrj=E4l=E4 Queued for -next, thanks for the patch. I've spotted this in a QA report, but afaik they didn't yet file a bug report. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch