From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: bdw: fix RC6 enabled status reporting and disable runtime PM
Date: Mon, 28 Apr 2014 15:46:37 +0200 [thread overview]
Message-ID: <20140428134637.GD32404@phenom.ffwll.local> (raw)
In-Reply-To: <1398675839-14962-1-git-send-email-imre.deak@intel.com>
On Mon, Apr 28, 2014 at 12:03:59PM +0300, Imre Deak wrote:
> On BDW we don't enable RC6 at the moment, but this isn't reflected in
> the (sanitized) i915.enable_rc6 option. So make enable_rc6 report
> correctly that RC6 is disabled, which will also effectively disable RPM
> on BDW (since RPM depends on RC6).
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77565
>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Officially we've merged runtime PM, but if it doesn't work we need to
temporarily disable. Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_pm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index d49ec02..19020e5 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3260,6 +3260,10 @@ static int sanitize_rc6_option(const struct drm_device *dev, int enable_rc6)
> if (INTEL_INFO(dev)->gen == 5 && !IS_IRONLAKE_M(dev))
> return 0;
>
> + /* Disable RC6 on Broadwell for now */
> + if (IS_BROADWELL(dev))
> + return 0;
> +
> /* Respect the kernel parameter if it is set */
> if (enable_rc6 >= 0) {
> int mask;
> --
> 1.8.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-04-28 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 9:03 [PATCH] drm/i915: bdw: fix RC6 enabled status reporting and disable runtime PM Imre Deak
2014-04-28 13:46 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428134637.GD32404@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox