From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/24] drm/i915: Shuffle wait_for_vblank out of primary_enable/disable funcs Date: Tue, 29 Apr 2014 16:00:52 +0200 Message-ID: <20140429140052.GS32404@phenom.ffwll.local> References: <1394209951-9963-1-git-send-email-ville.syrjala@linux.intel.com> <1394209951-9963-9-git-send-email-ville.syrjala@linux.intel.com> <20140408185545.GE18465@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by gabe.freedesktop.org (Postfix) with ESMTP id CE7BE6EA25 for ; Tue, 29 Apr 2014 07:00:57 -0700 (PDT) Received: by mail-ee0-f44.google.com with SMTP id c41so346845eek.17 for ; Tue, 29 Apr 2014 07:00:56 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140408185545.GE18465@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 08, 2014 at 09:55:45PM +0300, Ville Syrj=E4l=E4 wrote: > On Mon, Apr 07, 2014 at 05:27:41PM -0300, Paulo Zanoni wrote: > > 2014-03-07 13:32 GMT-03:00 : > > > From: Ville Syrj=E4l=E4 > > > > > > Rather than have a wait_for_vblank() in the primary plane enable/disa= ble > > > funcs, move the wait_for_vblank() to happen after enabling/disabling = all > > > planes. > > = > > Why exactly? What is improved? Are we solving a bug? What are the > > risks? What's the problem with the current code? Did you check the > > modeset sequence documentation of every single platform (since you > > changed them all) to make sure this is safe? > = > Just another step towards getting all the planes enabled/disabled > atomically during a modeset. I should have probably yanked it from > this series since it shouldn't be strictly needed for the watermark > stuff. At least I can't think of a reason now. I guess I included > it here just to make things a bit more difficult for the new watermark > update mechanism. > = > In any case there's nothing magical about the primary plane, so we > shouldn't treat it as such. That's my excuse for this patch anyway. > = > > Please update the commit message with the answers. > > = > > Also, we should probably update the first comment of hsw_enable_ips. > > It seems things have changed since it was written. > = > I thought I had. Ah no, that's part of the mmio vs. cs flip race series. > Looks like the wait for vblank changes there will conflict with this > stuff anyway. I'll have to revisit that series, and hopefully get it > merged before this series so that we can ignore this patch entirely. I'll ignore this one her for now ... -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch