From: Ben Widawsky <ben@bwidawsk.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] intel_error_decode: use 64b gtt_offset
Date: Tue, 29 Apr 2014 17:54:10 -0700 [thread overview]
Message-ID: <20140430005410.GA24177@bwidawsk.net> (raw)
In-Reply-To: <20140429090110.GL32404@phenom.ffwll.local>
On Tue, Apr 29, 2014 at 11:01:10AM +0200, Daniel Vetter wrote:
> On Tue, Apr 29, 2014 at 10:52:44AM +0200, Daniel Vetter wrote:
> > On Mon, Apr 28, 2014 at 06:45:50PM -0700, Ben Widawsky wrote:
> > > See the relevant kernel patch for the details. I guess this breaks
> > > support for older error state, I am not actually sure. Without
> > > versioning our error state though, I cannot think of a better way.
> > > Suggestions are welcome.
> >
> > Just drop the length qualifier and let scanf it the full number?
>
> Also, you know the drill: Testcase, please. A copy of drv_hangman to also
> feed the captured error state into intel_error_decode and check that it
> doesn't fall overr (exitcode != 0 and nothing on stderr). Maybe call it
> drv_error_decode or something like that.
> -Daniel
You're not going to get it from me. If you don't take the patch, that's
fine by me.
--
Ben Widawsky, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-04-30 0:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 0:18 [PATCH] drm/i915: Support 64b relocations Ben Widawsky
2014-04-29 1:11 ` [PATCH] drm/i915: Expand error state's address width to 64b Ben Widawsky
2014-04-29 1:43 ` [PATCH] [v2] " Ben Widawsky
2014-04-29 1:45 ` [PATCH] intel_error_decode: use 64b gtt_offset Ben Widawsky
2014-04-29 8:52 ` Daniel Vetter
2014-04-29 9:01 ` Daniel Vetter
2014-04-29 10:48 ` Chris Wilson
2014-04-29 11:05 ` Daniel Vetter
2014-04-30 0:54 ` Ben Widawsky [this message]
2014-05-01 8:06 ` [PATCH] [v2] drm/i915: Expand error state's address width to 64b Chris Wilson
2014-04-29 2:21 ` [PATCH] [v3] " Ben Widawsky
2014-04-29 2:29 ` [PATCH] drm/i915: Support 64b execbuf Ben Widawsky
2014-05-01 8:12 ` Chris Wilson
2014-05-01 10:18 ` Barbalho, Rafael
2014-05-05 14:02 ` Daniel Vetter
2014-05-01 8:04 ` [PATCH] drm/i915: Support 64b relocations Chris Wilson
2014-05-05 14:06 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430005410.GA24177@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox