From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Avoid NULL ctx->obj dereference in debugfs/i915_context_info
Date: Wed, 30 Apr 2014 14:40:32 +0200 [thread overview]
Message-ID: <20140430124032.GF20800@phenom.ffwll.local> (raw)
In-Reply-To: <871twft73z.fsf@intel.com>
On Wed, Apr 30, 2014 at 02:00:16PM +0300, Jani Nikula wrote:
> On Wed, 30 Apr 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Apr 30, 2014 at 08:30:00AM +0100, Chris Wilson wrote:
> >> In commit 691e6415c891b8b2b082a120b896b443531c4d45
> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
> >> Date: Wed Apr 9 09:07:36 2014 +0100
> >>
> >> drm/i915: Always use kref tracking for all contexts.
> >>
> >> we populated fake contexts on all platforms. These were identical to the
> >> full hardware context tracking structs, except for the ctx->obj used to
> >> store the hardware state. However, there remained one place where we
> >> assumed that if a context existed, it would have an object associated
> >> with it.
> >>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77717
> >> Testcase: igt/drv_suspend/debugfs-reader
> >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Queued for -next, thanks for the patch.
>
> Why not -fixes? "drm/i915: Always use kref tracking for all contexts" is
> present in v3.15-rc2.
I guess we could merge it to -fixes, otoh this is for debugfs ... Dunno
whether we should throw this at grumpy Linus really.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-04-30 12:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 7:30 [PATCH] drm/i915: Avoid NULL ctx->obj dereference in debugfs/i915_context_info Chris Wilson
2014-04-30 7:37 ` Daniel Vetter
2014-04-30 11:00 ` Jani Nikula
2014-04-30 12:40 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430124032.GF20800@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox