From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Avoid NULL ctx->obj dereference
 in debugfs/i915_context_info
Date: Wed, 30 Apr 2014 14:40:32 +0200
Message-ID: <20140430124032.GF20800@phenom.ffwll.local>
References: <1398843000-16108-1-git-send-email-chris@chris-wilson.co.uk>
 <20140430073752.GC20800@phenom.ffwll.local>
 <871twft73z.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42])
 by gabe.freedesktop.org (Postfix) with ESMTP id 836736E184
 for <intel-gfx@lists.freedesktop.org>; Wed, 30 Apr 2014 05:40:38 -0700 (PDT)
Received: by mail-ee0-f42.google.com with SMTP id d17so1342313eek.29
 for <intel-gfx@lists.freedesktop.org>; Wed, 30 Apr 2014 05:40:36 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <871twft73z.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Apr 30, 2014 at 02:00:16PM +0300, Jani Nikula wrote:
> On Wed, 30 Apr 2014, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Wed, Apr 30, 2014 at 08:30:00AM +0100, Chris Wilson wrote:
> >> In commit 691e6415c891b8b2b082a120b896b443531c4d45
> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
> >> Date:   Wed Apr 9 09:07:36 2014 +0100
> >> 
> >>     drm/i915: Always use kref tracking for all contexts.
> >> 
> >> we populated fake contexts on all platforms. These were identical to the
> >> full hardware context tracking structs, except for the ctx->obj used to
> >> store the hardware state. However, there remained one place where we
> >> assumed that if a context existed, it would have an object associated
> >> with it.
> >> 
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77717
> >> Testcase: igt/drv_suspend/debugfs-reader
> >> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Queued for -next, thanks for the patch.
> 
> Why not -fixes? "drm/i915: Always use kref tracking for all contexts" is
> present in v3.15-rc2.

I guess we could merge it to -fixes, otoh this is for debugfs ... Dunno
whether we should throw this at grumpy Linus really.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch