From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/bdw: Don't allow the FBC base to be 0 Date: Fri, 2 May 2014 16:00:25 +0300 Message-ID: <20140502130024.GT18465@intel.com> References: <1398995274-1317-1-git-send-email-benjamin.widawsky@intel.com> <20140502081927.GR18465@intel.com> <20140502083811.GA21695@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D931C6E52B for ; Fri, 2 May 2014 06:00:30 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140502083811.GA21695@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Ben Widawsky , Intel GFX , Art Runyan , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On Fri, May 02, 2014 at 09:38:11AM +0100, Chris Wilson wrote: > On Fri, May 02, 2014 at 11:19:27AM +0300, Ville Syrj=E4l=E4 wrote: > > On Thu, May 01, 2014 at 06:47:54PM -0700, Ben Widawsky wrote: > > > "Restriction : > > > The offset must be greater than 4K bytes, avoiding the first 4KB of > > > stolen memory." > > = > > Isn't this a more generic issue that we must avoid the first 4k? If so > > I think we should just reserve the first 4k permanently at driver init > > time. > = > What? On many machines the vga framebuffer is allocated from offset 0. I > think some explanation is in order. WaSkipStolenMemoryFirstPage -- = Ville Syrj=E4l=E4 Intel OTC