From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: remove extraneous VGA power domain put calls
Date: Tue, 6 May 2014 21:31:18 +0200 [thread overview]
Message-ID: <20140506193118.GE5730@phenom.ffwll.local> (raw)
In-Reply-To: <20140425161442.GU18465@intel.com>
On Fri, Apr 25, 2014 at 07:14:42PM +0300, Ville Syrjälä wrote:
> On Fri, Apr 25, 2014 at 05:28:00PM +0300, Imre Deak wrote:
> > In recent dmesg logs reported for unrelated issues I noticed some power
> > domain WARNs caused by the following.
> >
> > The workaround
> >
> > commit ce352550327b394f3072a07c9cd9d27af9276f15
> > Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Date: Fri Sep 20 10:14:23 2013 +0300
> >
> > drm/i915: Fix unclaimed register access due to delayed VGA memory disable
> >
> > and following fixup of it
> >
> > commit a14853206517b0c8102accbc77401805a0dbdb9e
> > Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Date: Mon Sep 16 17:38:34 2013 +0300
> >
> > drm/i915: Move power well init earlier during driver load
> >
> > was partially reverted by
> >
> > commit 7f16e5c1416070dc590dd333a2d677700046a4ab
> > Merge: 9d1cb91 5e01dc7
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date: Mon Nov 4 16:28:47 2013 +0100
> >
> > Merge tag 'v3.12' into drm-intel-next
> >
> > but kept the power domain put calls on the error path.
> >
> > I think for now we can keep things as-is (not reintroduce the w/a) and just fix
> > the error path, since
> > - nobody complained seeing this issue
> > - according to Ville someone is reworking the VGA arbitration scheme at the
> > moment and when that's ready we have to rethink this part anyway
> >
> > So fix this by just removing the put calls from the error path as well.
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Oops, forgotten to mention that this one is merged to dinq.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-05-06 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 14:28 [PATCH] drm/i915: remove extraneous VGA power domain put calls Imre Deak
2014-04-25 16:14 ` Ville Syrjälä
2014-05-06 19:31 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506193118.GE5730@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox