From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915: remove extraneous VGA power
 domain put calls
Date: Tue, 6 May 2014 21:31:18 +0200
Message-ID: <20140506193118.GE5730@phenom.ffwll.local>
References: <1398436080-20882-1-git-send-email-imre.deak@intel.com>
 <20140425161442.GU18465@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43])
 by gabe.freedesktop.org (Postfix) with ESMTP id 5A90E6E398
 for <intel-gfx@lists.freedesktop.org>; Tue,  6 May 2014 12:31:23 -0700 (PDT)
Received: by mail-ee0-f43.google.com with SMTP id d17so60277eek.30
 for <intel-gfx@lists.freedesktop.org>; Tue, 06 May 2014 12:31:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140425161442.GU18465@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Apr 25, 2014 at 07:14:42PM +0300, Ville Syrj=E4l=E4 wrote:
> On Fri, Apr 25, 2014 at 05:28:00PM +0300, Imre Deak wrote:
> > In recent dmesg logs reported for unrelated issues I noticed some power
> > domain WARNs caused by the following.
> > =

> > The workaround
> > =

> > commit ce352550327b394f3072a07c9cd9d27af9276f15
> > Author: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Date:   Fri Sep 20 10:14:23 2013 +0300
> > =

> >     drm/i915: Fix unclaimed register access due to delayed VGA memory d=
isable
> > =

> > and following fixup of it
> > =

> > commit a14853206517b0c8102accbc77401805a0dbdb9e
> > Author: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>
> > Date:   Mon Sep 16 17:38:34 2013 +0300
> > =

> >     drm/i915: Move power well init earlier during driver load
> > =

> > was partially reverted by
> > =

> > commit 7f16e5c1416070dc590dd333a2d677700046a4ab
> > Merge: 9d1cb91 5e01dc7
> > Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> > Date:   Mon Nov 4 16:28:47 2013 +0100
> > =

> >     Merge tag 'v3.12' into drm-intel-next
> > =

> > but kept the power domain put calls on the error path.
> > =

> > I think for now we can keep things as-is (not reintroduce the w/a) and =
just fix
> > the error path, since
> > - nobody complained seeing this issue
> > - according to Ville someone is reworking the VGA arbitration scheme at=
 the
> >   moment and when that's ready we have to rethink this part anyway
> > =

> > So fix this by just removing the put calls from the error path as well.
> > =

> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> =

> Reviewed-by: Ville Syrj=E4l=E4 <ville.syrjala@linux.intel.com>

Oops, forgotten to mention that this one is merged to dinq.
-Daniel
-- =

Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch