From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] igt tests/gem_exec_params: Test for -EINVAL
 for invalid platform and ring when executing RS
Date: Wed, 7 May 2014 00:42:12 +0200
Message-ID: <20140506224211.GJ5730@phenom.ffwll.local>
References: <1399412453-28379-1-git-send-email-abdiel.janulgue@linux.intel.com>
 <20140506224013.GI5730@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46])
 by gabe.freedesktop.org (Postfix) with ESMTP id 2F1866E414
 for <intel-gfx@lists.freedesktop.org>; Tue,  6 May 2014 15:42:16 -0700 (PDT)
Received: by mail-ee0-f46.google.com with SMTP id t10so168837eei.19
 for <intel-gfx@lists.freedesktop.org>; Tue, 06 May 2014 15:42:15 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140506224013.GI5730@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Wed, May 07, 2014 at 12:40:13AM +0200, Daniel Vetter wrote:
> On Wed, May 07, 2014 at 12:40:53AM +0300, Abdiel Janulgue wrote:
> > Add test that makes sure RS bit only gets executed on BDW and
> > on the render ring.
> > 
> > Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> > ---
> >  tests/gem_exec_params.c |   11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> > index 769969d..a3f765b 100644
> > --- a/tests/gem_exec_params.c
> > +++ b/tests/gem_exec_params.c
> > @@ -193,6 +193,17 @@ igt_main
> >  		execbuf.num_cliprects = 0;
> >  	}
> >  
> > +	igt_subtest("rs-not-gen8") {
> > +                igt_require(intel_gen(devid) != 8);
> > +                execbuf.flags = I915_EXEC_RENDER | I915_EXEC_RESOURCE_STREAMER;
> > +                RUN_FAIL(EINVAL);
> > +        }
> > +
> > +	igt_subtest("invalid-rs-ring") {
> > +		execbuf.flags = I915_EXEC_RESOURCE_STREAMER;
> > +		RUN_FAIL(EINVAL);
> 
> See Chris comment, but 0 is actually _not_ an invalid ring, but aliases
> RCS. Yeah, we have a fun api. So this should actually suceed, at least on
> bdw (and -EINVAL everywhere else).
> 
> So you need to explicitly test with some other ring like VCS
> (I915_EXEC_BSD).

Also you didn't update the invalid-flag subtest ... I wonder why that
didn't fail on bdw.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch