From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 2/9] drm/i915: Extract node allocation from bind Date: Wed, 7 May 2014 10:30:57 -0700 Message-ID: <20140507173057.GA7663@bwidawsk.net> References: <1399440098-17378-1-git-send-email-benjamin.widawsky@intel.com> <1399440098-17378-2-git-send-email-benjamin.widawsky@intel.com> <20140507070238.GD7322@nuc-i3427.alporthouse.com> <20140507154536.GB5147@bwidawsk.net> <20140507155308.GH7322@nuc-i3427.alporthouse.com> <20140507160015.GD5147@bwidawsk.net> <20140507165500.GJ7322@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id F03566ED74 for ; Wed, 7 May 2014 10:31:02 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140507165500.GJ7322@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Wed, May 07, 2014 at 05:55:00PM +0100, Chris Wilson wrote: > On Wed, May 07, 2014 at 09:00:16AM -0700, Ben Widawsky wrote: > > On Wed, May 07, 2014 at 04:53:08PM +0100, Chris Wilson wrote: > > > On Wed, May 07, 2014 at 08:45:38AM -0700, Ben Widawsky wrote: > > > > Hmm. I really don't see what's actually upsetting. Can you be a bit more > > > > explicit about what's so bothersome to you for my edification? > > > > > > evict_something() make assumptions about the ranges of the vm which it > > > searches. At the moment, they mirror its parent's function. > > > > Ah, thanks. So is plumbing starting eviction offset into evict something an > > appealing solution here? > > Yes. I have to admit to not being overly sold on the code migration yet. > I guess you have an ulterior motive... Evictable vm? > -Chris > The only immediate goal is to be able to get this bit logic out of bind_to_vm, so I can use "preallocated" nodes a bit more cleanly. At least for the present, I have no plans with it other than that. I did like the resuse of the PDE allocation for gen7. If I think of a better reason, I'll let you know. -- Ben Widawsky, Intel Open Source Technology Center