From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jamey Sharp <jamey@minilop.net>
Subject: Re: [PATCH] UXA: Wait until a pageflip actually
 completes to report it.
Date: Wed, 7 May 2014 22:44:23 -0700
Message-ID: <20140508054423.GA9791@minilop.net>
References: <1399356307-7392-1-git-send-email-jamey@minilop.net>
 <20140507155518.GI7322@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1653532620=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com
 [209.85.220.49])
 by gabe.freedesktop.org (Postfix) with ESMTP id CD7426E5C6
 for <intel-gfx@lists.freedesktop.org>; Wed,  7 May 2014 22:44:27 -0700 (PDT)
Received: by mail-pa0-f49.google.com with SMTP id lj1so2231527pab.8
 for <intel-gfx@lists.freedesktop.org>; Wed, 07 May 2014 22:44:27 -0700 (PDT)
In-Reply-To: <20140507155518.GI7322@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org, Theo Hill <Theo0x48@gmail.com>
List-Id: intel-gfx@lists.freedesktop.org


--===============1653532620==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy"
Content-Disposition: inline


--gBBFr7Ir9EOA20Yy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 07, 2014 at 04:55:18PM +0100, Chris Wilson wrote:
> On Mon, May 05, 2014 at 11:05:07PM -0700, Jamey Sharp wrote:
> > UXA was reporting page-flip completion as soon as the flip was scheduled
> > with the kernel, instead of waiting for the kernel to indicate that the
> > flip had actually completed.
> >=20
> > Moving the DRI2SwapComplete call to the right place fixes all of our
> > Piglit tests for OML_sync_control when run on xf86-video-intel/UXA,
> > aside from a bit of difficult-to-reproduce flakiness when using a
> > divisor > 1.
>=20
> The violation is intentional, as it gives us triple buffering by
> default. It can be disabled.

As far as I can tell, this patch has no effect on triple-buffering. I
verified that by logging new_front->handle in intel_do_pageflip: It
rotates through three different BO's on successive flips.

Jamey

--gBBFr7Ir9EOA20Yy
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlNrGbUACgkQp1aplQ4I9mVs0wCfYjiWPQHj9/LYcU+rOFHPoygL
xY4AnAoQ1AQUPvXqfCvBFzMKl1/xhQZy
=vMyK
-----END PGP SIGNATURE-----

--gBBFr7Ir9EOA20Yy--

--===============1653532620==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1653532620==--