From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms
Date: Fri, 9 May 2014 12:09:46 +0300 [thread overview]
Message-ID: <20140509090946.GS18465@intel.com> (raw)
In-Reply-To: <20140509060309.GH3443@nuc-i3427.alporthouse.com>
On Fri, May 09, 2014 at 07:03:09AM +0100, Chris Wilson wrote:
> On Thu, May 08, 2014 at 07:23:15PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The pipe might not start to actually run until the port has been enabled
> > (depends on the platform and port type). So don't try to wait for vblank
> > after we enabled the pipe but haven't yet enabled the port.
>
> I am pretty sure those waits were in the docs. Pretty sure, not certain
> though.
I didn't find them anywhere. The only vblank waits I see are the ones
for gen2 between disabling the planes and the pipe since the pipe
disable isn't double buffered on vblank. And that wait is still there
due to intel_disable_primary_hw_plane(). If my mmio vs. CS flip race
series ever gets reviewed that also gets killed, but I do add back an
explicit vblank wait for gen2 only into i9xx_crtc_disable().
--
Ville Syrjälä
Intel OTC
next prev parent reply other threads:[~2014-05-09 9:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 16:23 [PATCH 0/4] drm/i915: Reorder planes vs. modeset on gmch platforms ville.syrjala
2014-05-08 16:23 ` [PATCH 1/4] drm/i915: Convert gmch platforms over to ilk_crtc_{enable, disable}_planes() ville.syrjala
2014-05-09 6:02 ` Chris Wilson
2014-05-12 16:47 ` Daniel Vetter
2014-05-12 19:58 ` Daniel Vetter
2014-05-08 16:23 ` [PATCH 2/4] drm/i915: Disable/enable planes as the first/last thing during modeset on gmch platforms ville.syrjala
2014-05-09 6:22 ` Chris Wilson
2014-05-09 9:28 ` Ville Syrjälä
2014-05-13 8:23 ` Chris Wilson
2014-05-08 16:23 ` [PATCH 3/4] drm/i915: Kill vblank waits after pipe enable " ville.syrjala
2014-05-09 6:03 ` Chris Wilson
2014-05-09 9:09 ` Ville Syrjälä [this message]
2014-05-13 8:28 ` Chris Wilson
2014-05-13 9:02 ` Daniel Vetter
2014-05-08 16:23 ` [PATCH 4/4] drm/i915: Move the drm_vblank_on() calls to intel_crtc_enable_planes() ville.syrjala
2014-05-09 5:53 ` Chris Wilson
2014-05-12 16:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140509090946.GS18465@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox