From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/4] drm/i915: Convert gmch platforms over to ilk_crtc_{enable, disable}_planes()
Date: Mon, 12 May 2014 18:47:05 +0200 [thread overview]
Message-ID: <20140512164705.GP25056@phenom.ffwll.local> (raw)
In-Reply-To: <20140509060208.GG3443@nuc-i3427.alporthouse.com>
On Fri, May 09, 2014 at 07:02:08AM +0100, Chris Wilson wrote:
> On Thu, May 08, 2014 at 07:23:13PM +0300, ville.syrjala@linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Use the same code for enabling/disabling planes on all platforms. Rename
> > the functions to reflect that they're no longer specific to any
> > platform.
> >
> > For now we leave the plane enable/disable to ccur at the same old
> > position in the modeset sequence.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I think this looks ok, I didn't spot any functional change.
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Merged, with the usual drm_vblank_on conflict frobbed.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-05-12 16:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 16:23 [PATCH 0/4] drm/i915: Reorder planes vs. modeset on gmch platforms ville.syrjala
2014-05-08 16:23 ` [PATCH 1/4] drm/i915: Convert gmch platforms over to ilk_crtc_{enable, disable}_planes() ville.syrjala
2014-05-09 6:02 ` Chris Wilson
2014-05-12 16:47 ` Daniel Vetter [this message]
2014-05-12 19:58 ` Daniel Vetter
2014-05-08 16:23 ` [PATCH 2/4] drm/i915: Disable/enable planes as the first/last thing during modeset on gmch platforms ville.syrjala
2014-05-09 6:22 ` Chris Wilson
2014-05-09 9:28 ` Ville Syrjälä
2014-05-13 8:23 ` Chris Wilson
2014-05-08 16:23 ` [PATCH 3/4] drm/i915: Kill vblank waits after pipe enable " ville.syrjala
2014-05-09 6:03 ` Chris Wilson
2014-05-09 9:09 ` Ville Syrjälä
2014-05-13 8:28 ` Chris Wilson
2014-05-13 9:02 ` Daniel Vetter
2014-05-08 16:23 ` [PATCH 4/4] drm/i915: Move the drm_vblank_on() calls to intel_crtc_enable_planes() ville.syrjala
2014-05-09 5:53 ` Chris Wilson
2014-05-12 16:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512164705.GP25056@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox