From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/4] drm/i915: Convert gmch platforms over to ilk_crtc_{enable, disable}_planes() Date: Mon, 12 May 2014 18:47:05 +0200 Message-ID: <20140512164705.GP25056@phenom.ffwll.local> References: <1399566196-25086-1-git-send-email-ville.syrjala@linux.intel.com> <1399566196-25086-2-git-send-email-ville.syrjala@linux.intel.com> <20140509060208.GG3443@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f42.google.com (mail-ee0-f42.google.com [74.125.83.42]) by gabe.freedesktop.org (Postfix) with ESMTP id 1619D6E73D for ; Mon, 12 May 2014 09:47:09 -0700 (PDT) Received: by mail-ee0-f42.google.com with SMTP id d49so4933505eek.29 for ; Mon, 12 May 2014 09:47:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140509060208.GG3443@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, May 09, 2014 at 07:02:08AM +0100, Chris Wilson wrote: > On Thu, May 08, 2014 at 07:23:13PM +0300, ville.syrjala@linux.intel.com w= rote: > > From: Ville Syrj=E4l=E4 > > = > > Use the same code for enabling/disabling planes on all platforms. Rename > > the functions to reflect that they're no longer specific to any > > platform. > > = > > For now we leave the plane enable/disable to ccur at the same old > > position in the modeset sequence. > > = > > Signed-off-by: Ville Syrj=E4l=E4 > = > I think this looks ok, I didn't spot any functional change. > Reviewed-by: Chris Wilson Merged, with the usual drm_vblank_on conflict frobbed. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch