From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 05/10] drm: add a path blob property Date: Tue, 13 May 2014 10:25:36 +0200 Message-ID: <20140513082535.GI6754@ulmo> References: <1399877207-15868-1-git-send-email-airlied@gmail.com> <1399877207-15868-6-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1242095796==" Return-path: In-Reply-To: <1399877207-15868-6-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1242095796== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IbA9xpzOQlG26JSn" Content-Disposition: inline --IbA9xpzOQlG26JSn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 12, 2014 at 04:46:42PM +1000, Dave Airlie wrote: > From: Dave Airlie >=20 > This property will be used by the MST code to provide userspace > with a path to parse so it can recognise connectors around hotplugs. >=20 > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/drm_crtc.c | 26 ++++++++++++++++++++++++++ > include/drm/drm_crtc.h | 5 +++++ > 2 files changed, 31 insertions(+) The documentation for this property is missing. =3D) > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c [...] > +int drm_mode_connector_set_path_property(struct drm_connector *connector, > + char *path) "const char *path"? > +{ > + struct drm_device *dev =3D connector->dev; > + int ret, size; > + size =3D strlen(path) + 1; At the risk of sounding pedantic: strlen() returns size_t, not int. But I see that drm_property_create_blob() uses int as the type for the length argument, so there's an inconsistency either way. I'll go prepare a patch to fix that inconsistency and see if anybody else is equally pedantic and willing to apply it. Thierry --IbA9xpzOQlG26JSn Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTcdb/AAoJEN0jrNd/PrOhii4P/3rlYa3uq+xSnOI9GWJvuj5K ZFrIdtraka7vu9R9gSlfw6FzPWSFXi5aJ2DXlO+bIpXnPF9yBURNqFfpYdifkNce 2df19w550WxStltSSfBtLa2ph8WRtpjm67XXakvVgMf1rCtubOHozgVfISgQZH8f T6bDabavkz9XHGHQ5ZqSub2VwFBiy12FBua+rDY+3XZe7bUbk6y0Nj2QO7/1KVy5 YlQuRLR6E8A+9sfGGuqYpUtBP70Ti+00IZyXgijKy7h2G2OYmk7wJvN+LatLZbSR RuvNuKt1zP3J6jUyFXES5PcQi+oVlE90BuZnfHI4xq3rfjA42PfnikJM9IGbgbAJ 0IwlaKMcLt+n9xQDt8t1NxXvf3qYBWDDwxh/fiZYeAxtD11kpDp0LWZcxJhw2gt2 XUie9Bq1MPF9h2xb3jyMzKEKC4RKoTanVMeKopYRKIAsUuWYXsas7DTcV/OC0LgC Ap8V3vy8krKUKEtgV8B61PDIpi3Txk1zNFEv6K3bhjlcMu4rJ5yY6CGhm2O9A577 1dSiBgGdP06l20EOWwYGWz3L/rg8Q2hRX1/ZwmDCmVeJeOrKhlqrCn54k+ktgE2Z Wu3w6kGQRV+0Byjz3CMVFH285X//TfNzbaMrLlYTcIlmtLD1sFrcP0mhLEAzgwwU qDx4eTWaSI7kg1qNfIBF =lyFT -----END PGP SIGNATURE----- --IbA9xpzOQlG26JSn-- --===============1242095796== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1242095796==--