From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 10/10] i915: mst topology dumper in debugfs Date: Tue, 13 May 2014 10:33:27 +0200 Message-ID: <20140513083326.GK6754@ulmo> References: <1399877207-15868-1-git-send-email-airlied@gmail.com> <1399877207-15868-11-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1874786774==" Return-path: In-Reply-To: <1399877207-15868-11-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1874786774== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLauP2uySp+9cKYP" Content-Disposition: inline --SLauP2uySp+9cKYP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, May 12, 2014 at 04:46:47PM +1000, Dave Airlie wrote: [...] > @@ -3813,6 +3838,7 @@ static const struct drm_info_list i915_debugfs_list[] = { > {"i915_pc8_status", i915_pc8_status, 0}, > {"i915_power_domain_info", i915_power_domain_info, 0}, > {"i915_display_info", i915_display_info, 0}, > + {"i915_dp_mst_info", i915_dp_mst_info, 0}, This isn't really specific to this patch, but I've been thinking for a while if perhaps it would be a good idea to try to unify debugfs across drivers to some degree. What I mean by that is try to use common names for files with similar functionality. Off the top of my head I think a couple of drivers expose a list of framebuffers via debugfs, mostly using duplicated code and different file names. Sharing the code would of course be easy, but I think there may be some advantage to keeping the names consistent as well. Given its generic nature, MST sounds like a good candidate as well. Thierry --SLauP2uySp+9cKYP Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTcdjWAAoJEN0jrNd/PrOhSlEQAL8XS3proFkAcxnxTd6DAbPD zxmhvtWqabwQbObxiw+uW6kRStb+8+KU/OG827XPVd1JFCP6arQWlX39HN4dugpb fFw2weHDr1MFwdwxP1gJ84YHWcfv4pbaf6h9evkvhkZaZcYgNn4uvfjRWehLJ6M/ xDkBxeBlSo0lTgw833bypTp0gKYBk1W/8yEPbPKw6aT7Y9LR0nxjzJU0a+0Cj3zi 0yZDdPypjVoIPpfIKv0dQwHEVpOYOGzKlAscColxA+wNqJvk2uw5vk3q9Ec48/1g 2hWwu++Xqg1jdXZvAC65z4gFiOIjNnHlRIJKQxj0tkAdYZEEZUEhIgOTuQaWdfMF geqfs1nIAg/ekcGZazJEfjrjHEoQCpqZDr/scQo+9AkOEM88zIFUg9cstCHq2OYe ZbK0oeWo9JzcAltE/cd+q7+9JcwDpzdwCyhU4Js955p/XlzeYWqJq+XF5n5+HTqJ PmAsA0El+zujKmX2nAZL9NdOi1WTdZtYI2BGOGwTyMUJr3ZFhmCo5aQH/K41FTle xURMdQFboTWdaq+QvZW5AW994Uni7LKtKZgd6ETbEN0Q1wUwtMYunPIfWjpMggzu 7ELn7zjZaU05vqCSQmk/AqJ6tpDVAVr3g9R8vIwbH4mWNlUVmaOdnPsuQ+ZGMULd YZj0SRRsuN21a65RUMvo =ny+r -----END PGP SIGNATURE----- --SLauP2uySp+9cKYP-- --===============1874786774== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1874786774==--