From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 04/10] drm/crtc: add interface to reinitialise the legacy mode group Date: Tue, 13 May 2014 12:15:47 +0200 Message-ID: <20140513101547.GA3908@phenom.ffwll.local> References: <1399877207-15868-1-git-send-email-airlied@gmail.com> <1399877207-15868-5-git-send-email-airlied@gmail.com> <20140513082655.GJ6754@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by gabe.freedesktop.org (Postfix) with ESMTP id C630C6EA50 for ; Tue, 13 May 2014 03:15:56 -0700 (PDT) Received: by mail-we0-f178.google.com with SMTP id u56so130608wes.37 for ; Tue, 13 May 2014 03:15:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20140513082655.GJ6754@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Thierry Reding Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Tue, May 13, 2014 at 10:26:56AM +0200, Thierry Reding wrote: > On Mon, May 12, 2014 at 04:46:41PM +1000, Dave Airlie wrote: > > From: Dave Airlie > > > > This can be called to update things after dynamic connectors/encoders > > are created/deleted. > > > > Signed-off-by: Dave Airlie > > --- > > drivers/gpu/drm/drm_crtc.c | 9 +++++++++ > > include/drm/drm_crtc.h | 1 + > > 2 files changed, 10 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index f1753e6..8bf87a6 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -1421,6 +1421,15 @@ int drm_mode_group_init_legacy_group(struct drm_device *dev, > > } > > EXPORT_SYMBOL(drm_mode_group_init_legacy_group); > > > > +void drm_reinit_primary_mode_group(struct drm_device *dev) > > +{ > > + drm_modeset_lock_all(dev); > > + drm_mode_group_destroy(&dev->primary->mode_group); > > + drm_mode_group_init_legacy_group(dev, &dev->primary->mode_group); > > + drm_modeset_unlock_all(dev); > > +} > > +EXPORT_SYMBOL(drm_reinit_primary_mode_group); > > + > > /** > > * drm_crtc_convert_to_umode - convert a drm_display_mode into a modeinfo > > * @out: drm_mode_modeinfo struct to return to the user > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index c6b9e8a..55bc523 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -916,6 +916,7 @@ extern const char *drm_get_tv_select_name(int val); > > extern void drm_fb_release(struct drm_file *file_priv); > > extern int drm_mode_group_init_legacy_group(struct drm_device *dev, struct drm_mode_group *group); > > extern void drm_mode_group_destroy(struct drm_mode_group *group); > > +extern void drm_reinit_primary_mode_group(struct drm_device *dev); > > There was a patch series once to remove all usage of extern from > prototypes. Was there an official decision against that which I missed, > or did it just fall off the table? Iirc I've done that for radeon or so and we decided that it's a bikeshed. tbh I don't care, but in i915 I tend to rip them out since redundant. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch