From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 10/10] i915: mst topology dumper in debugfs Date: Tue, 13 May 2014 12:40:54 +0200 Message-ID: <20140513104052.GC8407@ulmo> References: <1399877207-15868-1-git-send-email-airlied@gmail.com> <1399877207-15868-11-git-send-email-airlied@gmail.com> <20140513083326.GK6754@ulmo> <20140513101835.GB3908@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2053187997==" Return-path: In-Reply-To: <20140513101835.GB3908@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============2053187997== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oJ71EGRlYNjSvfq7" Content-Disposition: inline --oJ71EGRlYNjSvfq7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 13, 2014 at 12:18:35PM +0200, Daniel Vetter wrote: > On Tue, May 13, 2014 at 10:33:27AM +0200, Thierry Reding wrote: > > On Mon, May 12, 2014 at 04:46:47PM +1000, Dave Airlie wrote: > > [...] > > > @@ -3813,6 +3838,7 @@ static const struct drm_info_list i915_debugfs_= list[] =3D { > > > {"i915_pc8_status", i915_pc8_status, 0}, > > > {"i915_power_domain_info", i915_power_domain_info, 0}, > > > {"i915_display_info", i915_display_info, 0}, > > > + {"i915_dp_mst_info", i915_dp_mst_info, 0}, > >=20 > > This isn't really specific to this patch, but I've been thinking for a > > while if perhaps it would be a good idea to try to unify debugfs across > > drivers to some degree. What I mean by that is try to use common names > > for files with similar functionality. Off the top of my head I think a > > couple of drivers expose a list of framebuffers via debugfs, mostly > > using duplicated code and different file names. Sharing the code would > > of course be easy, but I think there may be some advantage to keeping > > the names consistent as well. >=20 > Imo our current approach of having seq_file helpers in libraries that > drivers can use works well. At least with i915 we often want to add some > more driver-private state to dumps (e.g. for framebuffers), so extracting > more than what's already extracted is probably hard to do. Good point. > But I guess we could add some common files with e.g. just the core > framebuffer stuff to all drivers. Not terribly motivated myself though > since i915 has it all already ;-) I was thinking it would be convenient if there was some consistency between the debugfs interfaces of the various drivers to make it easier for people to find equivalent information sources. On second thought maybe that's not such a useful idea after all since some of the files may expose similar, but not exactly the same, information, given that some of it may be driver-specific. Thierry --oJ71EGRlYNjSvfq7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTcfa0AAoJEN0jrNd/PrOhmeUP/A47ob2k3bKOjlJBGwxVSGuA gWeIRcPZFEnOwWLcpkXp780m9ryMHEWYlSNlJtY3K/3QW4C1FHBjbohSIkQYpXJ7 +8brxdghlCKmCV1/bLq7OlPvZu6MZB66yKo42xGhun1Wud9+qqESX94pqvBwgVZ3 8sYn82covK1MDRtZip4hUtsCqClU0K3SmimjdmBxGqNmObYgHndeePGRhF+9FANC B9N7jKW8+duOAXhuZ0+6/wj2LlacIiWOJC7j/WHcGGci3qt1Hh5a7f1PsWhQrcox T3Lwh0xAIrOUqwWhbNVdVDH+iPbUIFSOQ87xanPUXOJU/VNqBT41wQOH/pvvjS1j sSXryEid2KxL6M7xyv6JqqiUjnijYJbWzZe/jRoEfsp9yy5L52FyMMaaCHHXFP9K lXhrSDU8UBiEACKwkgKDyaSYAebfEKQbA6qhuWXB/sFO6Hi1Q6ccBk6CLWvKU+gl IeESqG3kbaEE5EQ5p9K9qybuDZbQKdsfdINYhSi+8Rg5Ws5IqlzANlXq2CY4OLFV 43G5e5EFQxg0bqyFQTB9MVnAE42eCW2qwMC7QSHKYvP/EVSDOLduzAE0ZzEk7Gcz lhYHkKiEMGDDSOkzFYK6OhjNMSUjH94VWKj1/17UTEVgvXJ+SMY9crA9Xqva1/Vm CbmWEmydCtq3uCR/NsEs =ZakL -----END PGP SIGNATURE----- --oJ71EGRlYNjSvfq7-- --===============2053187997== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============2053187997==--