From: Damien Lespiau <damien.lespiau@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use the connector name in fbdev debug messages
Date: Tue, 13 May 2014 14:02:58 +0100 [thread overview]
Message-ID: <20140513130258.GC11767@strange.icx.intel.com> (raw)
In-Reply-To: <20140513125916.GJ7239@nuc-i3427.alporthouse.com>
On Tue, May 13, 2014 at 01:59:16PM +0100, Chris Wilson wrote:
> On Tue, May 13, 2014 at 01:51:46PM +0100, Damien Lespiau wrote:
> > On Tue, May 13, 2014 at 01:45:09PM +0100, Chris Wilson wrote:
> > > - DRM_DEBUG_KMS("connector %s on crtc %d: %s\n",
> > > + DRM_DEBUG_KMS("connector %s on pipe %d [CRTC:%d]: %dx%d%s\n",
> > > drm_get_connector_name(connector),
> > > + pipe_name(to_intel_crtc(encoder->crtc)->pipe),
> >
> > pipe_name() gives you a char.
>
> Using name was an afterthought. But other than, sane?
Yes! With that fixed, definitely a
Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
--
Damien
next prev parent reply other threads:[~2014-05-13 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 12:45 [PATCH] drm/i915: Use the connector name in fbdev debug messages Chris Wilson
2014-05-13 12:51 ` Damien Lespiau
2014-05-13 12:59 ` Chris Wilson
2014-05-13 13:02 ` Damien Lespiau [this message]
2014-05-13 13:26 ` Chris Wilson
2014-05-13 14:02 ` Daniel Vetter
2014-05-13 14:11 ` Chris Wilson
2014-05-14 10:07 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513130258.GC11767@strange.icx.intel.com \
--to=damien.lespiau@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox