From mboxrd@z Thu Jan  1 00:00:00 1970
From: Damien Lespiau <damien.lespiau@intel.com>
Subject: Re: [PATCH] drm/i915: Use the connector name in fbdev
 debug messages
Date: Tue, 13 May 2014 14:02:58 +0100
Message-ID: <20140513130258.GC11767@strange.icx.intel.com>
References: <1399985109-31679-1-git-send-email-chris@chris-wilson.co.uk>
 <20140513125146.GB11767@strange.icx.intel.com>
 <20140513125916.GJ7239@nuc-i3427.alporthouse.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTP id 6B2976E30C
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 May 2014 06:03:27 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20140513125916.GJ7239@nuc-i3427.alporthouse.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, May 13, 2014 at 01:59:16PM +0100, Chris Wilson wrote:
> On Tue, May 13, 2014 at 01:51:46PM +0100, Damien Lespiau wrote:
> > On Tue, May 13, 2014 at 01:45:09PM +0100, Chris Wilson wrote:
> > > -		DRM_DEBUG_KMS("connector %s on crtc %d: %s\n",
> > > +		DRM_DEBUG_KMS("connector %s on pipe %d [CRTC:%d]: %dx%d%s\n",
> > >  			      drm_get_connector_name(connector),
> > > +			      pipe_name(to_intel_crtc(encoder->crtc)->pipe),
> > 
> > pipe_name() gives you a char.
> 
> Using name was an afterthought. But other than, sane?

Yes! With that fixed, definitely a

Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

-- 
Damien